-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More sophisticated measurement validation for default-qubit #5890
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5890 +/- ##
==========================================
- Coverage 99.67% 99.67% -0.01%
==========================================
Files 426 426
Lines 40924 40654 -270
==========================================
- Hits 40791 40520 -271
- Misses 133 134 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of non-blocking comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🚀
I guess moving away from a fixed set of observables to this check regarding diagonalizing gates creates the opportunity to define your own observables. Since that's sort of an 'added functionality' here, should we add a test for it?
Description of the Change:
Add measurement-specific observable validations to measurement validation
[sc-64700]