Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More sophisticated measurement validation for default-qubit #5890

Merged
merged 19 commits into from
Jul 11, 2024
Merged

Conversation

astralcai
Copy link
Contributor

Description of the Change:
Add measurement-specific observable validations to measurement validation

[sc-64700]

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.67%. Comparing base (6d0a528) to head (162c66b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5890      +/-   ##
==========================================
- Coverage   99.67%   99.67%   -0.01%     
==========================================
  Files         426      426              
  Lines       40924    40654     -270     
==========================================
- Hits        40791    40520     -271     
- Misses        133      134       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astralcai astralcai marked this pull request as ready for review July 10, 2024 15:38
Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of non-blocking comments.

pennylane/devices/preprocess.py Show resolved Hide resolved
tests/workflow/test_construct_batch.py Show resolved Hide resolved
tests/devices/qubit/test_measure.py Show resolved Hide resolved
@lillian542 lillian542 self-requested a review July 11, 2024 13:48
Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

I guess moving away from a fixed set of observables to this check regarding diagonalizing gates creates the opportunity to define your own observables. Since that's sort of an 'added functionality' here, should we add a test for it?

@astralcai astralcai enabled auto-merge (squash) July 11, 2024 18:13
@astralcai astralcai merged commit 38d2685 into master Jul 11, 2024
40 checks passed
@astralcai astralcai deleted the obs-stop branch July 11, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants