-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform to split sums into single terms #5884
Conversation
[sc-60187] |
[sc-60188] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5884 +/- ##
==========================================
- Coverage 99.67% 99.67% -0.01%
==========================================
Files 425 426 +1
Lines 40926 40660 -266
==========================================
- Hits 40793 40526 -267
- Misses 133 134 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All comments from me are minor and non-blocking. No concerns from my side :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Although with this much overlap between this and split_non_commuting
, I wonder if it is worth it to unify the two at some point in the future.
Then we'd have to rename it, since this doesn't split things that don't commute... perhaps we could call it |
Co-authored-by: Christina Lee <christina@xanadu.ai>
Co-authored-by: Christina Lee <christina@xanadu.ai>
@trbromley I added a note on each transform that I hope clarifies |
Context:
Some simulators can handle non-commuting observables but don't take multi-term observables.
Description of the Change:
We add a transform that splits the observables on a tape up into single-term observables. This transform relies heavily on the
no_grouping
functionality already implemented insplit_non_commuting
. However, instead of splitting the measurements across many tapes, all of the measurements are returned on a single tape.