Optimize PhaseShift, T, S gates #5876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5876 +/- ##
==========================================
- Coverage 99.67% 99.67% -0.01%
==========================================
Files 426 426
Lines 40875 40625 -250
==========================================
- Hits 40742 40491 -251
- Misses 133 134 +1 ☔ View full report in Codecov by Sentry. |
trbromley
reviewed
Jul 5, 2024
There was a problem hiding this comment.
Thanks @vincentmr! Please could you attach the corresponding Shortcut story?
mudit2812
reviewed
Jul 8, 2024
mudit2812
reviewed
Jul 8, 2024
|
Tests are failing because of Catalyst, I'll just wait for the release and ping reviewers again. |
1 similar comment
|
Tests are failing because of Catalyst, I'll just wait for the release and ping reviewers again. |
albi3ro
reviewed
Jul 8, 2024
albi3ro
reviewed
Jul 8, 2024
albi3ro
approved these changes
Jul 9, 2024
mudit2812
approved these changes
Jul 9, 2024
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
RenkeHuang
pushed a commit
to RenkeHuang/pennylane
that referenced
this pull request
Jul 11, 2024
### Before submitting
Please complete the following checklist when submitting a PR:
- [x] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
test directory!
- [x] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [x] Ensure that the test suite passes, by running `make test`.
- [x] Add a new entry to the `doc/releases/changelog-dev.md` file,
summarizing the
change, and including a link back to the PR.
- [x] The PennyLane source code conforms to
[PEP8 standards](https://www.python.org/dev/peps/pep-0008/).
We check all of our code against [Pylint](https://www.pylint.org/).
To lint modified files, simply `pip install pylint`, and then
run `pylint pennylane/path/to/file.py`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:**
`PauliZ` has a fast implementation which relies on the sparsity of the
operator in `DefaultQubit`. Several operations have the same non-zero
matrix elements and could be similarly accelerated. One candidate is
`PhaseShift` which is abundantly used in `iterative_qpe`.
**Description of the Change:**
Port the fast-`PauliZ` to `PhaseShift` and use the implementation for
`PauliZ`, `S` and `T`.
**Benefits:**
Faster execution. For example the simple system
```
nwires = 24
dev = qml.device("default.qubit", shots=1)
@qml.qnode(dev)
def circuit(iters):
for i in range(iters):
qml.PhaseShift(0.1234, i % nwires)
return qml.sample(wires=[0])
circuit(100)
```
takes 0m13.178s on `master` and 0m9.146s on `optim_apply_operations`. We
observe the same speed-up for `S` and `T`.
**Possible Drawbacks:**
**Related GitHub Issues:**
[sc-67827]
---------
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
test directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
doc/releases/changelog-dev.mdfile, summarizing thechange, and including a link back to the PR.
The PennyLane source code conforms to
PEP8 standards.
We check all of our code against Pylint.
To lint modified files, simply
pip install pylint, and thenrun
pylint pennylane/path/to/file.py.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
PauliZhas a fast implementation which relies on the sparsity of the operator inDefaultQubit. Several operations have the same non-zero matrix elements and could be similarly accelerated. One candidate isPhaseShiftwhich is abundantly used initerative_qpe.Description of the Change:
Port the fast-
PauliZtoPhaseShiftand use the implementation forPauliZ,SandT.Benefits:
Faster execution. For example the simple system
takes 0m13.178s on
masterand 0m9.146s onoptim_apply_operations. We observe the same speed-up forSandT.Possible Drawbacks:
Related GitHub Issues:
[sc-67827]