-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new qiskit device as the base for remote #566
Merged
austingmhuang
merged 40 commits into
new_device_feature_branch
from
use_new_qiskit_device
Jul 12, 2024
Merged
Changes from 13 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
d3bae16
import changes
austingmhuang 736f7a3
Added TODOs for tests
austingmhuang e1154e4
changes
austingmhuang 50022b0
this should pass
austingmhuang 1d30fb8
merge confs
austingmhuang 39e50c7
pylint
austingmhuang e907588
circular import
austingmhuang b4abc71
observables update
austingmhuang af5bfa4
remerge
austingmhuang 61d057d
import from qiskitdevice2
austingmhuang d8cbc03
Delete unnecessary tests and mocks
austingmhuang 5d10756
black/pylint
austingmhuang 07be9e6
Add tests back in for codecov.
austingmhuang 4ec53d9
refactor tests
austingmhuang b0b5a8a
delete legacy device only functionality
austingmhuang 8606376
change around imports
austingmhuang 9777375
add assertion
austingmhuang 991beae
merge conflicts
austingmhuang aedb433
fix
austingmhuang c798126
fix
austingmhuang 211e575
Merge branch 'new_device_feature_branch' into use_new_qiskit_device
austingmhuang d0285ad
fix setup
austingmhuang 5eb2438
Merge branch 'new_device_feature_branch' into use_new_qiskit_device
austingmhuang 8c35d83
clean up
austingmhuang d3eedd3
fix reqs.txt
austingmhuang 2e4685e
Merge branch 'new_device_feature_branch' into use_new_qiskit_device
austingmhuang d5d8545
fix
austingmhuang 761958c
changelog changed
austingmhuang cc82285
merg conf
austingmhuang 44a595b
maybe this works?
austingmhuang c015f29
a docstring?
austingmhuang e4df301
a docstring?
austingmhuang 04cb4bf
reverts
austingmhuang 8c8555f
does this break
austingmhuang f55f82c
revert
austingmhuang bb4933f
fix
austingmhuang e6794ce
fix
austingmhuang 394ac48
attempt a doc fix
obliviateandsurrender 58d30a5
Update tests/test_integration.py
austingmhuang daaa889
some docstrings
austingmhuang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since
QISKIT_OPERATION_MAP
isn't really a "legacy" object but will be used by the new device and conversion going forward, should we move it to either the newqiskit_device
folder or toconverter
, and update imports accordingly?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I personally lean towards moving it to converter (to me it seems more like a utility thing?) so that, suppose in 5 years we have a new new device, this import doesn't need to change. Plus it just makes sense intuitively to import the
QISKIT_OPERATION_MAP
from the file where it is actually defined.