-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Tensor and Hamiltonian in python frontend for lightning #994
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #994 +/- ##
==========================================
- Coverage 98.00% 92.14% -5.86%
==========================================
Files 231 104 -127
Lines 36387 16266 -20121
==========================================
- Hits 35662 14989 -20673
- Misses 725 1277 +552 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks @lillian542 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lillian542 . Awesome. Just wondering if same action is required for lightning_tensor
?
@multiphaseCFD thanks, good question! It doesn't import or any custom code for Hamiltonian or Tensor, so I had discounted it, but I went back and checked and "Hamiltonian" was still on the list of supported ops, which it preferably shouldn't be. I've updated that now; as far as I can see, nothing else in the code for that device is specific to the legacy opmath. |
Thanks @lillian542 . Could you please also add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maliasadi and @lillian542, we have some C++ tests that emulate the data structure of a Tensor and/or Hamiltonian. Are we renaming, updating or removing these tests? Or are we going to leave it for now?
Lilian, please refresh my mind, what will be substituting these in the new opmath?
@multiphaseCFD if we need to make changes in the C++ backend, would it be alight for that to happen in a different PR? Since PennyLane runs tests with The The |
Thanks @lillian542 . Good question. I would suggest to create a new PR to work on the C++ layer changes as long as current changes in the frontend do not break the pipeline. But I would like to ask @maliasadi to decide. |
@AmintorDusko @multiphaseCFD @lillian542 We don't need any changes in C++ right now as Lightning and Catalyst continue serializing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lillian542 for the nice work! Happy to approve!
We are removing the Tensor and Hamiltonian classes, so we should remove their (minimal) remaining references in the Lightning python code. Blocks running CI for the [PL PR legacy_opmath, since every test that uses `lightning.qubit` fails with Tensor removed. --------- Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>
We are removing the Tensor and Hamiltonian classes, so we should remove their (minimal) remaining references in the Lightning python code. Blocks running CI for the [PL PR legacy_opmath, since every test that uses `lightning.qubit` fails with Tensor removed. --------- Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>
We are removing the Tensor and Hamiltonian classes, so we should remove their (minimal) remaining references in the Lightning python code.
Blocks running CI for the PL PR #6548 to remove legacy_opmath, since every test that uses
lightning.qubit
fails with Tensor removed.[sc-77523]