Optimize lightning.tensor by adding direct MPS sites data set
#983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
…tning into statePrep_MPS
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #983 +/- ##
==========================================
- Coverage 97.93% 96.06% -1.87%
==========================================
Files 233 233
Lines 39905 39070 -835
==========================================
- Hits 39079 37532 -1547
- Misses 826 1538 +712 ☔ View full report in Codecov by Sentry. |
…tning into statePrep_MPS
LuisAlfredoNu
added
the
ci:use-gpu-runner
…tning into statePrep_MPS
pennylane_lightning/core/src/simulators/lightning_tensor/utils/tncuda_utils/tncuda_helpers.hpp
Show resolved
Hide resolved
maliasadi
reviewed
Dec 19, 2024
pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/TNCuda.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/TNCuda.hpp
Show resolved
Hide resolved
...ane_lightning/core/src/simulators/lightning_tensor/tncuda/bindings/LTensorTNCudaBindings.hpp
Show resolved
Hide resolved
...ane_lightning/core/src/simulators/lightning_tensor/tncuda/bindings/LTensorTNCudaBindings.hpp
Outdated
Show resolved
Hide resolved
...ane_lightning/core/src/simulators/lightning_tensor/tncuda/bindings/LTensorTNCudaBindings.hpp
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_tensor/utils/tncuda_utils/tncuda_helpers.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_tensor/utils/tncuda_utils/tncuda_helpers.hpp
Outdated
Show resolved
Hide resolved
LuisAlfredoNu
requested review from
josephleekl,
multiphaseCFD and
maliasadi
josephleekl
reviewed
Dec 19, 2024
pennylane_lightning/core/src/simulators/lightning_tensor/utils/tncuda_utils/tncuda_helpers.hpp
Show resolved
Hide resolved
josephleekl
reviewed
Dec 19, 2024
pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/tests/Tests_MPSTNCuda.cpp
Outdated
Show resolved
Hide resolved
josephleekl
reviewed
Dec 19, 2024
...ane_lightning/core/src/simulators/lightning_tensor/tncuda/bindings/LTensorTNCudaBindings.hpp
Show resolved
Hide resolved
josephleekl
reviewed
Dec 19, 2024
josephleekl
reviewed
Dec 19, 2024
josephleekl
reviewed
Dec 20, 2024
pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/TNCuda.hpp
Outdated
Show resolved
Hide resolved
josephleekl
reviewed
Dec 20, 2024
pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/TNCuda.hpp
Outdated
Show resolved
Hide resolved
josephleekl
reviewed
Dec 20, 2024
pennylane_lightning/core/src/simulators/lightning_tensor/utils/tncuda_utils/tncuda_helpers.hpp
Outdated
Show resolved
Hide resolved
josephleekl
reviewed
Dec 20, 2024
pennylane_lightning/core/src/simulators/lightning_tensor/utils/tncuda_utils/tncuda_helpers.hpp
Outdated
Show resolved
Hide resolved
josephleekl
reviewed
Dec 20, 2024
|
Added some small comments, happy to approve straight away once they're dealt with! @LuisAlfredoNu |
josephleekl
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Optimize
lightning.tensorby adding direct MPS sites data setDescription of the Change:
Adding the
MPSPrepgate to be able to pass an MPS directly to the Tensor Network.The
MPSPrepgate frontend was developed on this PRBenefits:
Avoid the decomposition from state vector to MPS sites which are expensive and inefficient
Possible Drawbacks:
Related GitHub Issues:
[sc-74709]