-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standard installation instruction visibility #979
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #979 +/- ##
===========================================
- Coverage 97.72% 28.70% -69.03%
===========================================
Files 228 28 -200
Lines 36378 2505 -33873
===========================================
- Hits 35550 719 -34831
- Misses 828 1786 +958 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Approved pending
- Rebase to master
- Making sure there aren't any merge conflicts
- All tests pass
@maliasadi this PR should be good to go now, pending testing + your review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AntonNI8! Feel free to merge the PR after updating the changelog 🎉
Context:
The standard (default, preferred) installation instructions in the pennylane-lightning docs are easy to miss.
This could discourage users if they think they need to go through a more involved installation process, ie. installing from source.
Description of the Change:
Added a heading for standard installation instructions.
Benefits:
Easier to notice the most simple/straightforward installation method for lightning devices.
Possible Drawbacks:
Related GitHub Issues: