Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NumPy 1.19.5 for building the wheels #97

Merged
merged 8 commits into from
Apr 30, 2021
Merged

Use NumPy 1.19.5 for building the wheels #97

merged 8 commits into from
Apr 30, 2021

Conversation

antalszava
Copy link
Contributor

@antalszava antalszava commented Apr 29, 2021

  • The PennyLane-Lightning binaries are now built with NumPy 1.19.5, to avoid ABI
    compatibility issues with the latest NumPy 1.20 release. See
    the NumPy release notes
    for more details.
  • Prepares the 1.15.1 release

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #97 (da777f6) into master (b0910bc) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files           3        3           
  Lines          54       54           
=======================================
  Hits           53       53           
  Misses          1        1           
Impacted Files Coverage Δ
pennylane_lightning/_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0910bc...da777f6. Read the comment docs.

@josh146
Copy link
Member

josh146 commented Apr 29, 2021

Hey @antalszava, you'll need to explicitly modify the actions to ensure that numpy==1.19.5 is installed for building the wheels :) We can't leave the NumPy version used to build the wheels unpinned.

requirements.txt Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
antalszava and others added 2 commits April 30, 2021 10:45
Co-authored-by: Josh Izaac <josh146@gmail.com>
Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @antalszava 💯

CHANGELOG.md Outdated Show resolved Hide resolved
@josh146 josh146 marked this pull request as ready for review April 30, 2021 14:53
@antalszava antalszava merged commit 463d04b into master Apr 30, 2021
@antalszava antalszava deleted the check_numpy branch April 30, 2021 15:29
@antalszava antalszava changed the title Check that the GitHub actions for building the wheels install NumPy v1.19.5 well Use NumPy 1.19.5 for building the wheels Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants