-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LK catalyst shared object copy linux/mac only #947
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #947 +/- ##
===========================================
- Coverage 96.88% 53.46% -43.43%
===========================================
Files 215 28 -187
Lines 29522 2495 -27027
===========================================
- Hits 28603 1334 -27269
- Misses 919 1161 +242 ☔ View full report in Codecov by Sentry. |
Thanks @josephleekl ! LGTM. Don't forget to add an entry to the changelog and create a SC story for this PR and link the SC story to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @josephleekl 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm second to @maliasadi on limit the copy to linux system
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
BTW, would you like to add the |
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
This is a fix for this PR failing lightning kokkos build for non-linux systems.
[sc-76296]
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: