Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LK catalyst shared object copy linux/mac only #947

Merged
merged 8 commits into from
Oct 18, 2024

Conversation

josephleekl
Copy link
Contributor

@josephleekl josephleekl commented Oct 17, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
This is a fix for this PR failing lightning kokkos build for non-linux systems.

[sc-76296]
Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.46%. Comparing base (7c43ed6) to head (83c948e).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (7c43ed6) and HEAD (83c948e). Click for more details.

HEAD has 62 uploads less than BASE
Flag BASE (7c43ed6) HEAD (83c948e)
68 6
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #947       +/-   ##
===========================================
- Coverage   96.88%   53.46%   -43.43%     
===========================================
  Files         215       28      -187     
  Lines       29522     2495    -27027     
===========================================
- Hits        28603     1334    -27269     
- Misses        919     1161      +242     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@multiphaseCFD
Copy link
Member

Thanks @josephleekl ! LGTM. Don't forget to add an entry to the changelog and create a SC story for this PR and link the SC story to it.

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @josephleekl 🙌

setup.py Outdated Show resolved Hide resolved
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm second to @maliasadi on limit the copy to linux system

Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
@josephleekl josephleekl changed the title Disable LK catalyst shared object copy for macos Disable LK catalyst shared object copy for non-linux system Oct 17, 2024
@multiphaseCFD
Copy link
Member

BTW, would you like to add the ci_build_wheel label to ensure all CIs could pass? You can re-trigger the CI after choosing the label.

@josephleekl josephleekl added the ci:build_wheels Activate wheel building. label Oct 18, 2024
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
@multiphaseCFD multiphaseCFD added the ci:use-gpu-runner Enable usage of GPU runner for this Pull Request label Oct 18, 2024
@josephleekl josephleekl changed the title Disable LK catalyst shared object copy for non-linux system Fix LK catalyst shared object copy linux/mac only Oct 18, 2024
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@josephleekl josephleekl merged commit c719ac7 into master Oct 18, 2024
98 of 99 checks passed
@josephleekl josephleekl deleted the fix_lk_catalyst_install_macos branch October 18, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building. ci:use-gpu-runner Enable usage of GPU runner for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants