Update/actions #887
Merged
Update/actions #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
AmintorDusko
added
ci:build_wheels
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #887 +/- ##
==========================================
+ Coverage 90.55% 96.07% +5.52%
==========================================
Files 89 208 +119
Lines 11517 28162 +16645
==========================================
+ Hits 10429 27057 +16628
- Misses 1088 1105 +17 ☔ View full report in Codecov by Sentry. |
vincentmr
reviewed
Sep 4, 2024
There was a problem hiding this comment.
Thanks @AmintorDusko , disk space is a real nuisance so I hope retention-days: 1 will help.
maliasadi
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Nice work! Thanks @AmintorDusko 🥳 Feel free to merge it after updating the changelog.
AmintorDusko
added
github_actions
vincentmr
approved these changes
Sep 4, 2024
multiphaseCFD
pushed a commit
that referenced
this pull request
Sep 5, 2024
**Context:** GitHub Actions need to be updated. **Description of the Change:** GH detected a [high-severity](GHSA-cxww-7g56-2vh6) vulnerability, with the download artifact action. **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** [sc-72698] --------- Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>
This was referenced Sep 6, 2024
multiphaseCFD
pushed a commit
that referenced
this pull request
Sep 8, 2024
**Context:** GitHub Actions need to be updated. **Description of the Change:** GH detected a [high-severity](GHSA-cxww-7g56-2vh6) vulnerability, with the download artifact action. **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** [sc-72698] --------- Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>
maliasadi
added a commit
that referenced
this pull request
Sep 9, 2024
### Before submitting
Please complete the following checklist when submitting a PR:
- [ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
[`tests`](../tests) directory!
- [ ] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [ ] Ensure that the test suite passes, by running `make test`.
- [ ] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
change, and including a link back to the PR.
- [ ] Ensure that code is properly formatted by running `make format`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:**
As a followup to #887, this PR fixes the issue with the name of wheels
artifacts as per actions/upload-artifact#478
**Description of the Change:**
**Benefits:**
**Possible Drawbacks:**
**Related GitHub Issues:**
[sc-73124]
---------
Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: GitHub Actions need to be updated.
Description of the Change: GH detected a high-severity vulnerability, with the download artifact action.
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-72698]