Add controlled gate support to `lightning.tensor` #880

multiphaseCFD · 2024-08-29T20:35:25Z

Before submitting

Please complete the following checklist when submitting a PR:

All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running make docs.
Ensure that the test suite passes, by running make test.
Add a new entry to the .github/CHANGELOG.md file, summarizing the
change, and including a link back to the PR.
Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

Context:

Add controlled gate support to lightning.tensor. This could improve the performance of lightning.tensor by avoiding full gate matrix build for controlled gates. However, as of v24.08, cutensornet only supports controlled gates with only 1 wire target. [SC-72522]

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

…te_ltensor

codecov · 2024-09-04T14:32:50Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.50%. Comparing base (4bb34b7) to head (dd0ff41).
Report is 79 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (4bb34b7) and HEAD (dd0ff41). Click for more details.

HEAD has 55 uploads less than BASE

Flag BASE (4bb34b7) HEAD (dd0ff41)

64 9

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #880      +/-   ##
==========================================
- Coverage   96.54%   87.50%   -9.05%     
==========================================
  Files         208       62     -146     
  Lines       28740     5560   -23180     
==========================================
- Hits        27748     4865   -22883     
+ Misses        992      695     -297

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/TNCudaBase.hpp

vincentmr

Looks good @multiphaseCFD . Could you run these tests with Lightning-Tensor though?

.github/CHANGELOG.md

pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/TNCudaBase.hpp

LuisAlfredoNu

Everything looks super good. I do not have any comment. Thank you @multiphaseCFD

Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>

…a/TNCudaBase.hpp Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>

multiphaseCFD · 2024-09-05T15:08:27Z

Looks good @multiphaseCFD . Could you run these tests with Lightning-Tensor though?

Good point @vincentmr . Unfortunately not with current cutensornet API. As mentioned in the changelog, as of cutensornet v24.08, controlled gates API only support 1-wire target.

vincentmr · 2024-09-05T15:29:59Z

Unfortunately not with current cutensornet API. As mentioned in the changelog, as of cutensornet v24.08, controlled gates API only support 1-wire target.

Could you add a pytest.skip here when num_wires > 1?

multiphaseCFD · 2024-09-05T15:51:01Z

Unfortunately not with current cutensornet API. As mentioned in the changelog, as of cutensornet v24.08, controlled gates API only support 1-wire target.

Could you add a pytest.skip here when num_wires > 1?

Sure, done!

vincentmr

LGTM, nice @multiphaseCFD .

.github/CHANGELOG.md

Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>

...ane_lightning/core/src/simulators/lightning_tensor/tncuda/bindings/LTensorTNCudaBindings.hpp

maliasadi

Nice work! Thanks @multiphaseCFD 🚀

### Before submitting Please complete the following checklist when submitting a PR: - [ ] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the [`tests`](../tests) directory! - [ ] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running `make docs`. - [ ] Ensure that the test suite passes, by running `make test`. - [x] Add a new entry to the `.github/CHANGELOG.md` file, summarizing the change, and including a link back to the PR. - [x] Ensure that code is properly formatted by running `make format`. When all the above are checked, delete everything above the dashed line and fill in the pull request template. ------------------------------------------------------------------------------------------------------------ **Context:** Add controlled gate support to `lightning.tensor`. This could improve the performance of `lightning.tensor` by avoiding full gate matrix build for controlled gates. However, as of v24.08, cutensornet only supports controlled gates with only 1 wire target. [SC-72522] **Description of the Change:** **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** --------- Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai> Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com> Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>

multiphaseCFD and others added 22 commits August 29, 2024 19:11

initial commit

7e8de4f

initial commit

7530c0b

Auto update version from '0.38.0-dev52' to '0.38.0-dev53'

9b74d8c

make format

7b19154

add changelog entry

f0b78dd

Merge branch 'update_gatecache_access_ltensor' into add_controlled_ga…

a94c593

…te_ltensor

quick fix

de80863

add pybind layer

282c856

update dummy_tensor_update

dfd5c87

Add applyControlledMatrix pybindings

74ee7fb

safer dummy_tensor_update()

bc60ee6

tidy up code

aafa376

tidy up the code

c66db8e

more C++ layer tests

02f8b5a

add some unit tests

0427882

Merge branch 'master' into add_controlled_gate_ltensor

b81d308

remove duplicated methods

39cebc5

Auto update version from '0.39.0-dev0' to '0.39.0-dev1'

fb16e06

add unit tests for the non-empty

b6bdaa4

update changelog

4f521e1

add unit tests for lightning exceptions

f1c12f8

make format

e75958c

multiphaseCFD marked this pull request as ready for review September 4, 2024 14:11

multiphaseCFD requested review from maliasadi and vincentmr September 4, 2024 15:10

multiphaseCFD and others added 2 commits September 5, 2024 13:46

Merge branch 'master' into add_controlled_gate_ltensor

98cf6b8

Auto update version from '0.39.0-dev2' to '0.39.0-dev3'

ddbca7b

multiphaseCFD requested a review from LuisAlfredoNu September 5, 2024 14:04

Merge branch 'master' into add_controlled_gate_ltensor

52fc622

LuisAlfredoNu reviewed Sep 5, 2024

View reviewed changes

pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/TNCudaBase.hpp Show resolved Hide resolved

vincentmr suggested changes Sep 5, 2024

View reviewed changes

.github/CHANGELOG.md Outdated Show resolved Hide resolved

pennylane_lightning/core/src/simulators/lightning_tensor/tncuda/TNCudaBase.hpp Outdated Show resolved Hide resolved

LuisAlfredoNu approved these changes Sep 5, 2024

View reviewed changes

multiphaseCFD and others added 3 commits September 5, 2024 11:05

Update .github/CHANGELOG.md

2588c93

Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>

Update pennylane_lightning/core/src/simulators/lightning_tensor/tncud…

6f42c10

…a/TNCudaBase.hpp Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>

Auto update version from '0.39.0-dev3' to '0.39.0-dev4'

d515ff3

multiphaseCFD requested a review from vincentmr September 5, 2024 15:08

multiphaseCFD added 2 commits September 5, 2024 15:43

controlledWires -> controlled_wires

7994760

turn on more controlled gate tests

eab9f26

multiphaseCFD and others added 2 commits September 5, 2024 12:42

Merge branch 'master' into add_controlled_gate_ltensor

205fc15

Auto update version from '0.39.0-dev4' to '0.39.0-dev5'

e6e7663

vincentmr approved these changes Sep 5, 2024

View reviewed changes

maliasadi reviewed Sep 5, 2024

View reviewed changes

.github/CHANGELOG.md Outdated Show resolved Hide resolved

Update .github/CHANGELOG.md

cf1caed

Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>

maliasadi reviewed Sep 5, 2024

View reviewed changes

...ane_lightning/core/src/simulators/lightning_tensor/tncuda/bindings/LTensorTNCudaBindings.hpp Show resolved Hide resolved

maliasadi approved these changes Sep 5, 2024

View reviewed changes

multiphaseCFD added 2 commits September 6, 2024 13:32

Merge branch 'master' into add_controlled_gate_ltensor

da9a749

less number of control gate tests to speed up the CI

dd0ff41

multiphaseCFD merged commit c676ced into master Sep 6, 2024
81 of 90 checks passed

multiphaseCFD deleted the add_controlled_gate_ltensor branch September 6, 2024 15:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add controlled gate support to `lightning.tensor` #880

Add controlled gate support to `lightning.tensor` #880

multiphaseCFD commented Aug 29, 2024 •

edited

Loading

codecov bot commented Sep 4, 2024 •

edited

Loading

vincentmr left a comment

LuisAlfredoNu left a comment

multiphaseCFD commented Sep 5, 2024

vincentmr commented Sep 5, 2024

multiphaseCFD commented Sep 5, 2024

vincentmr left a comment

maliasadi left a comment

Add controlled gate support to lightning.tensor #880

Add controlled gate support to lightning.tensor #880

Conversation

multiphaseCFD commented Aug 29, 2024 • edited Loading

Before submitting

codecov bot commented Sep 4, 2024 • edited Loading

Codecov Report

vincentmr left a comment

Choose a reason for hiding this comment

LuisAlfredoNu left a comment

Choose a reason for hiding this comment

multiphaseCFD commented Sep 5, 2024

vincentmr commented Sep 5, 2024

multiphaseCFD commented Sep 5, 2024

vincentmr left a comment

Choose a reason for hiding this comment

maliasadi left a comment

Choose a reason for hiding this comment

Add controlled gate support to `lightning.tensor` #880

Add controlled gate support to `lightning.tensor` #880

multiphaseCFD commented Aug 29, 2024 •

edited

Loading

codecov bot commented Sep 4, 2024 •

edited

Loading