-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use decomposition
instead of Operator.expand
#846
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #846 +/- ##
===========================================
- Coverage 98.40% 80.99% -17.42%
===========================================
Files 113 17 -96
Lines 18413 1936 -16477
===========================================
- Hits 18120 1568 -16552
- Misses 293 368 +75 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @astralcai! Feel free to ping me again when you add the PR to ./.github/CHANGELOG.md
.
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, @astralcai!
`Operator.expand` is deprecated (PennyLaneAI/pennylane#5994). `Operator.decomposition` should be used instead. --------- Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai> Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Operator.expand
is deprecated (PennyLaneAI/pennylane#5994).Operator.decomposition
should be used instead.