Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for cutensornet v2.5.0 #845

Merged
merged 5 commits into from
Aug 9, 2024
Merged

Conversation

multiphaseCFD
Copy link
Member

@multiphaseCFD multiphaseCFD commented Aug 9, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

[sc-71130]

Set the immutable parameter value as false for the cutensornetStateApplyTensorOperator to allow the following cutensornetStateUpdateTensorOperator call.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@multiphaseCFD multiphaseCFD marked this pull request as ready for review August 9, 2024 20:46
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @multiphaseCFD 🥳 Will you close PR #844?

@multiphaseCFD
Copy link
Member Author

Awesome! Thanks @multiphaseCFD 🥳 Will you close PR #844?

Done!

Copy link
Contributor

@LuisAlfredoNu LuisAlfredoNu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @multiphaseCFD 👍

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.79%. Comparing base (3993e0b) to head (3e4663c).
Report is 86 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (3993e0b) and HEAD (3e4663c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3993e0b) HEAD (3e4663c)
8 7
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #845       +/-   ##
===========================================
- Coverage   93.74%   74.79%   -18.96%     
===========================================
  Files          97       58       -39     
  Lines       16029     4852    -11177     
===========================================
- Hits        15027     3629    -11398     
- Misses       1002     1223      +221     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@multiphaseCFD multiphaseCFD added the bug Something isn't working label Aug 9, 2024
@multiphaseCFD multiphaseCFD merged commit 27813be into master Aug 9, 2024
65 of 66 checks passed
@multiphaseCFD multiphaseCFD deleted the fix_cutensornet_v2.5 branch August 9, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants