-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shot batching is made more efficient by executing all the shots in one go on Lightning Qubit #814
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #814 +/- ##
==========================================
- Coverage 98.57% 93.63% -4.94%
==========================================
Files 114 17 -97
Lines 18069 1902 -16167
==========================================
- Hits 17812 1781 -16031
+ Misses 257 121 -136 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maliasadi ! Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maliasadi , LGTM. A few suggestions and then I'm ready to approve. Nice speed-ups for shot-vectors (thinking about it, I think I'd prefer speed-up plots instead of the time vs. XXX above; no need to change it here though).
Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code reduction, good speed-ups, nice PR @maliasadi !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @maliasadi !
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Shot batching is made more efficient by executing all the shots in one go on LightningQubit using
shots.bin
.Description of the Change:
_measure_with_samples_diagonalizing_gates
shots_vector
tests.Benefits:
Possible Drawbacks:
n/a
Related GitHub Issues:
[sc-66537]