Add var support to LTensor #804

multiphaseCFD · 2024-07-17T18:15:31Z

Before submitting

Please complete the following checklist when submitting a PR:

All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running make docs.
Ensure that the test suite passes, by running make test.
Add a new entry to the .github/CHANGELOG.md file, summarizing the
change, and including a link back to the PR.
Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

Context:

[SC-65783]

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

github-actions · 2024-07-17T18:18:33Z

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

A one-to-two sentence description of the change. You may include a small working example for new features.
A link back to this PR.
Your name (or GitHub username) in the contributors section.

### Before submitting Please complete the following checklist when submitting a PR: - [ ] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the [`tests`](../tests) directory! - [ ] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running `make docs`. - [ ] Ensure that the test suite passes, by running `make test`. - [x] Add a new entry to the `.github/CHANGELOG.md` file, summarizing the change, and including a link back to the PR. - [x] Ensure that code is properly formatted by running `make format`. When all the above are checked, delete everything above the dashed line and fill in the pull request template. ------------------------------------------------------------------------------------------------------------ **Context:** Add GPU device compute capability check. L-Tensor has device compute capability check like L-GPU now. [SC-69118] **Description of the Change:** **Benefits:** Error will be raised when running `lightning.tensor` on a unsupported GPU. **Possible Drawbacks:** **Related GitHub Issues:** #799 --------- Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>

codecov · 2024-07-18T02:56:13Z

Codecov Report

Attention: Patch coverage is 99.47917% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.84%. Comparing base (afb03e4) to head (2a98634).
Report is 85 commits behind head on master.

Files with missing lines	Patch %	Lines
...r/tncuda/observables/ObservablesTNCudaOperator.hpp	99.24%	1 Missing ⚠️
...nylane_lightning/lightning_tensor/_measurements.py	90.90%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #804      +/-   ##
==========================================
+ Coverage   98.50%   98.84%   +0.34%     
==========================================
  Files         111      116       +5     
  Lines       17900    18259     +359     
==========================================
+ Hits        17632    18049     +417     
+ Misses        268      210      -58

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pennylane_lightning/core/src/utils/cuda_utils/cuda_helpers.hpp

pennylane_lightning/core/src/utils/cuda_utils/cuGates_host.hpp

pennylane_lightning/core/src/utils/cuda_utils/LinearAlg.hpp

...htning/core/src/simulators/lightning_tensor/tncuda/observables/ObservablesTNCudaOperator.hpp

maliasadi

Nice work @multiphaseCFD! I have a few suggestions in my first round. I'll check tests and coverage tomorrow 🚀

...htning/core/src/simulators/lightning_tensor/tncuda/observables/ObservablesTNCudaOperator.hpp

pennylane_lightning/core/src/utils/cuda_utils/LinearAlg.hpp

pennylane_lightning/core/src/utils/cuda_utils/cuGates_host.hpp

pennylane_lightning/lightning_tensor/_measurements.py

tests/test_measurements.py

vincentmr

Nice progress @multiphaseCFD , and some more comments.

.github/CHANGELOG.md

...htning/core/src/simulators/lightning_tensor/tncuda/measurements/tests/Test_MPSTNCuda_Var.cpp

...htning/core/src/simulators/lightning_tensor/tncuda/observables/ObservablesTNCudaOperator.hpp

...htning/core/src/simulators/lightning_tensor/tncuda/measurements/tests/Test_MPSTNCuda_Var.cpp

...htning/core/src/simulators/lightning_tensor/tncuda/observables/ObservablesTNCudaOperator.hpp

pennylane_lightning/core/src/utils/cuda_utils/cuGates_host.hpp

LuisAlfredoNu

Nice work @multiphaseCFD!!! Good addition to Tensor backend

vincentmr

Neat refactor of the initialization logic. I think this is ready to go now. Thanks @multiphaseCFD .

...htning/core/src/simulators/lightning_tensor/tncuda/observables/ObservablesTNCudaOperator.hpp

maliasadi

Thanks @multiphaseCFD! 💯

pennylane_lightning/lightning_tensor/_measurements.py

Please complete the following checklist when submitting a PR: - [x] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the [`tests`](../tests) directory! - [ ] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running `make docs`. - [ ] Ensure that the test suite passes, by running `make test`. - [x] Add a new entry to the `.github/CHANGELOG.md` file, summarizing the change, and including a link back to the PR. - [x] Ensure that code is properly formatted by running `make format`. When all the above are checked, delete everything above the dashed line and fill in the pull request template. ------------------------------------------------------------------------------------------------------------ **Context:** [SC-65783] **Description of the Change:** **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** --------- Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>

multiphaseCFD added 5 commits July 16, 2024 20:36

init commit

9a0604a

make format

a3059ff

add unit tests for HermitianObs

9e83c44

initial commit

a929928

Merge branch 'master' into add_var_tensornet

1490267

multiphaseCFD changed the title ~~Add var support to LTensor~~ [WIP] Add var support to LTensor Jul 17, 2024

ringo-but-quantum and others added 6 commits July 17, 2024 18:18

Auto update version from '0.38.0-dev9' to '0.38.0-dev10'

3af11ac

make format

425126b

Auto update version from '0.38.0-dev10' to '0.38.0-dev11'

6da1e25

Merge branch 'master' into add_var_tensornet

9046199

Auto update version from '0.38.0-dev11' to '0.38.0-dev12'

3877ebf

multiphaseCFD and others added 16 commits July 18, 2024 15:55

make format

1b12733

add more complex Hermitian matrix

afa67c9

add python and pybind layer

49e529f

add more py unit tests

e97107e

add more unit tests

85a9bd5

add changelog

93ff20f

tidy up C++

fa2c8fb

further clean C++ layer

0cdc3d0

switch on more python unit tests

fca24d3

tidy up python layer

19dbedc

tidy up linaralg and add more unit tests

2737df1

Add var support to multi-terms Hamiltionian

976da4d

tidy up code

ad8d9bd

Auto update version from '0.38.0-dev12' to '0.38.0-dev13'

3ac6211

remove square_matrix_cuda_device

255e341

further tidy up

7b44e8a

LuisAlfredoNu reviewed Jul 31, 2024

View reviewed changes

pennylane_lightning/core/src/utils/cuda_utils/cuda_helpers.hpp Show resolved Hide resolved

LuisAlfredoNu reviewed Jul 31, 2024

View reviewed changes

pennylane_lightning/core/src/utils/cuda_utils/cuGates_host.hpp Show resolved Hide resolved

LuisAlfredoNu reviewed Jul 31, 2024

View reviewed changes

pennylane_lightning/core/src/utils/cuda_utils/LinearAlg.hpp Show resolved Hide resolved

multiphaseCFD requested a review from LuisAlfredoNu July 31, 2024 20:54

LuisAlfredoNu reviewed Jul 31, 2024

View reviewed changes

...htning/core/src/simulators/lightning_tensor/tncuda/observables/ObservablesTNCudaOperator.hpp Show resolved Hide resolved

maliasadi requested changes Jul 31, 2024

View reviewed changes

vincentmr reviewed Aug 1, 2024

View reviewed changes

multiphaseCFD added 7 commits August 1, 2024 12:56

resolve more comments

4fba502

resolve more comments

4f62281

further tidy up code

b2c8c2b

refactor ObservableTNCudaOperator ctor

63cd387

update python layer

bf670fc

mark pauli_map_ as static

cbb0d8d

move two paulis obskey construction to helper methods as well

7c35f9c

multiphaseCFD requested review from vincentmr, maliasadi and LuisAlfredoNu August 1, 2024 17:18

add unit tests to cover exceptions

fb1d7bc

LuisAlfredoNu approved these changes Aug 1, 2024

View reviewed changes

multiphaseCFD requested review from vincentmr and removed request for vincentmr August 2, 2024 13:49

vincentmr approved these changes Aug 2, 2024

View reviewed changes

...htning/core/src/simulators/lightning_tensor/tncuda/observables/ObservablesTNCudaOperator.hpp Outdated Show resolved Hide resolved

maliasadi approved these changes Aug 2, 2024

View reviewed changes

pennylane_lightning/lightning_tensor/_measurements.py Outdated Show resolved Hide resolved

multiphaseCFD and others added 4 commits August 2, 2024 14:11

tidy up code

17d3af3

Auto update version from '0.38.0-dev22' to '0.38.0-dev23'

2bd7f45

Merge branch 'master' into add_var_tensornet

e6f3ccd

Auto update version from '0.38.0-dev22' to '0.38.0-dev23'

2a98634

multiphaseCFD merged commit fb4e6c7 into master Aug 2, 2024
105 checks passed

multiphaseCFD deleted the add_var_tensornet branch August 2, 2024 15:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add var support to LTensor #804

Add var support to LTensor #804

multiphaseCFD commented Jul 17, 2024 •

edited

Loading

github-actions bot commented Jul 17, 2024

codecov bot commented Jul 18, 2024 •

edited

Loading

maliasadi left a comment

vincentmr left a comment

LuisAlfredoNu left a comment

vincentmr left a comment

maliasadi left a comment

Add var support to LTensor #804

Add var support to LTensor #804

Conversation

multiphaseCFD commented Jul 17, 2024 • edited Loading

Before submitting

github-actions bot commented Jul 17, 2024

codecov bot commented Jul 18, 2024 • edited Loading

Codecov Report

maliasadi left a comment

Choose a reason for hiding this comment

vincentmr left a comment

Choose a reason for hiding this comment

LuisAlfredoNu left a comment

Choose a reason for hiding this comment

vincentmr left a comment

Choose a reason for hiding this comment

maliasadi left a comment

Choose a reason for hiding this comment

multiphaseCFD commented Jul 17, 2024 •

edited

Loading

codecov bot commented Jul 18, 2024 •

edited

Loading