-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lightning stable plugin test matrix tests #783
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #783 +/- ##
===========================================
- Coverage 91.89% 27.88% -64.01%
===========================================
Files 126 17 -109
Lines 18490 1886 -16604
===========================================
- Hits 16991 526 -16465
+ Misses 1499 1360 -139 ☔ View full report in Codecov by Sentry. |
Links to tests: |
latest-stable is still failing due to MCM updates in the PL latest! I'd say this is not related to your PR and will be fixed with the next release. right? |
Yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Thank you, @maliasadi! |
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @AmintorDusko .
Thank you, @vincentmr! |
Context: Lightning stable version is incompatible with the latest Scipy version.
Description of the Change: We add a downgrade scipy version for some of the latest tests.
Benefits:
Possible Drawbacks:
Related GitHub Issues: