Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lightning stable plugin test matrix tests #783

Merged
merged 7 commits into from
Jul 3, 2024

Conversation

AmintorDusko
Copy link
Contributor

Context: Lightning stable version is incompatible with the latest Scipy version.

Description of the Change: We add a downgrade scipy version for some of the latest tests.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Copy link
Contributor

github-actions bot commented Jul 2, 2024

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@AmintorDusko AmintorDusko requested a review from maliasadi July 2, 2024 19:32
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.88%. Comparing base (84b5da5) to head (cfefe99).
Report is 95 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (84b5da5) and HEAD (cfefe99). Click for more details.

HEAD has 105 uploads less than BASE
Flag BASE (84b5da5) HEAD (cfefe99)
109 4
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #783       +/-   ##
===========================================
- Coverage   91.89%   27.88%   -64.01%     
===========================================
  Files         126       17      -109     
  Lines       18490     1886    -16604     
===========================================
- Hits        16991      526    -16465     
+ Misses       1499     1360      -139     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AmintorDusko
Copy link
Contributor Author

Links to tests:

@maliasadi
Copy link
Member

latest-stable is still failing due to MCM updates in the PL latest! I'd say this is not related to your PR and will be fixed with the next release. right?
stable-stable PASS :)

@AmintorDusko
Copy link
Contributor Author

latest-stable is still failing due to MCM updates in the PL latest! I'd say this is not related to your PR and will be fixed with the next release. right? stable-stable PASS :)

Yes.

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

.github/workflows/tests_lqcpu_python.yml Outdated Show resolved Hide resolved
@AmintorDusko
Copy link
Contributor Author

🙌

Thank you, @maliasadi!

AmintorDusko and others added 3 commits July 3, 2024 07:21
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
@AmintorDusko AmintorDusko requested a review from vincentmr July 3, 2024 11:25
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @AmintorDusko .

@AmintorDusko AmintorDusko merged commit 3d6db7a into master Jul 3, 2024
48 of 49 checks passed
@AmintorDusko AmintorDusko deleted the fix_lightning_stable_ptm_test branch July 3, 2024 13:07
@AmintorDusko
Copy link
Contributor Author

LGTM, thanks @AmintorDusko .

Thank you, @vincentmr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants