-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Scipy config file in LQ #775
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #775 +/- ##
==========================================
- Coverage 95.61% 94.32% -1.29%
==========================================
Files 109 109
Lines 15794 15776 -18
==========================================
- Hits 15101 14881 -220
- Misses 693 895 +202 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and truly happy to see this change. How many times have I added that config.h
file? Thanks @maliasadi .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A welcome change --- thanks @maliasadi
I assume the failing CI is fixed by #776
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Remove the required scipy config file used for the shots-based measurement processes in LQ. The support is now maintained by passing
SCIPY_LIBS_PATH
to the compiler.Description of the Change:
Use
add_compile_definitions
to pass the variable to the compiler instead of hardcoding it inconfig.h
.Benefits:
config.h
from LQ distro packagegit restore config.h
before each commitPossible Drawbacks:
Related GitHub Issues: