Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Scipy config file in LQ #775

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Remove Scipy config file in LQ #775

merged 5 commits into from
Jun 25, 2024

Conversation

maliasadi
Copy link
Member

@maliasadi maliasadi commented Jun 25, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
Remove the required scipy config file used for the shots-based measurement processes in LQ. The support is now maintained by passing SCIPY_LIBS_PATH to the compiler.

Description of the Change:
Use add_compile_definitions to pass the variable to the compiler instead of hardcoding it in config.h.

Benefits:

  • Remove config.h from LQ distro package
  • No need to run git restore config.h before each commit

Possible Drawbacks:

Related GitHub Issues:

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.32%. Comparing base (adef274) to head (da81df9).
Report is 94 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #775      +/-   ##
==========================================
- Coverage   95.61%   94.32%   -1.29%     
==========================================
  Files         109      109              
  Lines       15794    15776      -18     
==========================================
- Hits        15101    14881     -220     
- Misses        693      895     +202     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maliasadi maliasadi added the ci:build_wheels Activate wheel building. label Jun 25, 2024
@maliasadi maliasadi marked this pull request as ready for review June 25, 2024 15:38
@maliasadi maliasadi requested a review from a team June 25, 2024 15:38
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and truly happy to see this change. How many times have I added that config.h file? Thanks @maliasadi .

@maliasadi maliasadi requested review from mlxd June 25, 2024 17:10
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A welcome change --- thanks @maliasadi
I assume the failing CI is fixed by #776

@maliasadi maliasadi merged commit 042fa7c into master Jun 25, 2024
110 of 111 checks passed
@maliasadi maliasadi deleted the rm-scipy-config branch June 25, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants