-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Github action ternary op & expand wheel support #765
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #765 +/- ##
===========================================
- Coverage 95.24% 58.08% -37.16%
===========================================
Files 122 17 -105
Lines 17741 1904 -15837
===========================================
- Hits 16897 1106 -15791
+ Misses 844 798 -46 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: This PR aims to fix the issue encountered by https://github.com/PennyLaneAI/pennylane-lightning/actions/runs/9555317980
Description of the Change: "" -> '' and parenthesis around ternary op components. Expands supports to MacOS (x64/arm64) and Linux aarch64 too.
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-66316]