Fix random CI failures of lightning.tensor
#761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #761 +/- ##
==========================================
+ Coverage 90.14% 98.37% +8.23%
==========================================
Files 108 91 -17
Lines 14075 13742 -333
==========================================
+ Hits 12688 13519 +831
+ Misses 1387 223 -1164 ☔ View full report in Codecov by Sentry. |
multiphaseCFD
changed the title
lightning.tensor due to the missing of CUQUANTUM_SDK envlightning.tensor
|
Nice work! One more question. How did you check if the intermittent build failures are not happening anymore? |
vincentmr
approved these changes
Jun 13, 2024
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
Good question @AmintorDusko ! Not a strict criteria. Just re-triggered CI for 2-3 times and check if there is any failure for TN python CI tests. |
multiphaseCFD
added a commit
that referenced
this pull request
Jun 13, 2024
Please complete the following checklist when submitting a PR:
- [ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
[`tests`](../tests) directory!
- [ ] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [ ] Ensure that the test suite passes, by running `make test`.
- [x] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
change, and including a link back to the PR.
- [x] Ensure that code is properly formatted by running `make format`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:**
Currently, there are random CI build failures of `lightning.tensor` due
to the missing of `CUQUANTUM_SDK` env
**Description of the Change:**
Ignore `lightning_tensor` path in workflow
**Benefits:**
**Possible Drawbacks:**
**Related GitHub Issues:**
---------
Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
|
Late for the party. 😢 |
Another one is on the way @AmintorDusko 🔢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Currently, there are random CI build failures of
lightning.tensordue to the missing ofCUQUANTUM_SDKenvDescription of the Change:
Ignore
lightning_tensorpath in workflowBenefits:
Possible Drawbacks:
Related GitHub Issues: