Fix the issue with initializing LK with zero-qubit and invalid number of control_wires in ctrl_decomp_zyz #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentmr
reviewed
Jun 7, 2024
maliasadi
force-pushed
the
maa-lk-decom-fixes
branch
from
82318f5 to
d4944fd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #757 +/- ##
==========================================
+ Coverage 92.92% 97.74% +4.82%
==========================================
Files 122 66 -56
Lines 17846 9042 -8804
==========================================
- Hits 16583 8838 -7745
+ Misses 1263 204 -1059 ☔ View full report in Codecov by Sentry. |
vincentmr
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
LGTM, happy to approve @maliasadi . Go ahead and merge when the CI goes green.
multiphaseCFD
approved these changes
Jun 7, 2024
multiphaseCFD
pushed a commit
that referenced
this pull request
Jun 7, 2024
… of control_wires in ctrl_decomp_zyz (#757) Please complete the following checklist when submitting a PR: - [x] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the [`tests`](../tests) directory! - [x] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running `make docs`. - [ ] Ensure that the test suite passes, by running `make test`. - [x] Add a new entry to the `.github/CHANGELOG.md` file, summarizing the change, and including a link back to the PR. - [x] Ensure that code is properly formatted by running `make format`. When all the above are checked, delete everything above the dashed line and fill in the pull request template. ------------------------------------------------------------------------------------------------------------ **Context:** - [X] Fix the issue with initializing `lightning.kokkos` with zero-qubit and - [X] Invalid number of control_wires in ctrl_decomp_zyz (PR PennyLaneAI/pennylane#5735) - [x] Add test for `device('lightning.kokkos', wires=0)` **Description of the Change:** **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** Fixes #751 --------- Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
lightning.kokkoswith zero-qubit anddevice('lightning.kokkos', wires=0)Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
Fixes #751