Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove release-release-compat-check action schedule #746

Merged
merged 3 commits into from
May 29, 2024

Conversation

maliasadi
Copy link
Member

@maliasadi maliasadi commented May 29, 2024

Context:
The Compat Check w/PL - release/release is scheduled daily while this action is only required during the release weeks. This PR removes the daily schedule. We can still trigger this manually using wokflow_dispatch if needed before starting the next release.

Description of the Change:
as explained above.

Benefits:
no daily runs of this unnecessary action!

Possible Drawbacks:
n/a

Related Issues:
[sc-64481]

@maliasadi maliasadi requested a review from a team May 29, 2024 19:07
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, don't forget to update the changelog though.

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@maliasadi maliasadi merged commit 24e72f1 into master May 29, 2024
49 of 56 checks passed
@maliasadi maliasadi deleted the rm-rel-rel-schedule branch May 29, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants