Update LightningQubit to adhere to MCM qnode arguments
#736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudit2812
commented
May 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #736 +/- ##
==========================================
- Coverage 94.57% 92.71% -1.87%
==========================================
Files 122 15 -107
Lines 17781 1729 -16052
==========================================
- Hits 16816 1603 -15213
+ Misses 965 126 -839 ☔ View full report in Codecov by Sentry. |
trbromley
reviewed
May 23, 2024
vincentmr
reviewed
Jun 3, 2024
vincentmr
approved these changes
Jun 5, 2024
multiphaseCFD
pushed a commit
that referenced
this pull request
Jun 5, 2024
**Context:** As name says. `QNode` now accepts `postselect_shots` and `mcm_method` arguments to specify MCM behaviour. This PR updates LQ to adhere to those arguments. **Description of the Change:** * Update LQ preprocessing to adhere to user requested MCM behaviour * Add tests for LQ and LK * Update LQ and LK simulation to adhere to specified `postselect_mode`. **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** --------- Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
As name says.
QNodenow acceptspostselect_shotsandmcm_methodarguments to specify MCM behaviour. This PR updates LQ to adhere to those arguments.Description of the Change:
postselect_mode.Benefits:
Possible Drawbacks:
Related GitHub Issues: