Remove CPhase + Tidy up src #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #717 +/- ##
==========================================
+ Coverage 93.91% 95.35% +1.44%
==========================================
Files 107 91 -16
Lines 16244 14073 -2171
==========================================
- Hits 15255 13419 -1836
+ Misses 989 654 -335 ☔ View full report in Codecov by Sentry. |
maliasadi
force-pushed
the
maa/fix-cphase-minor
branch
from
b237ec4 to
dbeaaa3
Compare
maliasadi
changed the title
multiphaseCFD
approved these changes
May 9, 2024
pennylane_lightning/core/src/simulators/lightning_gpu/measurements/MeasurementsGPU.hpp
Show resolved
Hide resolved
vincentmr
approved these changes
May 9, 2024
There was a problem hiding this comment.
A couple questions, but ready to approve ... so I'll approve. Thanks @maliasadi , nice one.
multiphaseCFD
pushed a commit
that referenced
this pull request
May 13, 2024
* Remove CPhase; Tidy up NDPermuter, gh scripts, and doc * Add release_notes to docs * Auto update version from '0.37.0-dev0' to '0.37.0-dev2' * Update changelog * Auto update version from '0.37.0-dev2' to '0.37.0-dev3' * trigger ci * Revert change in config.h * Update * Update * Update * Auto update version from '0.37.0-dev3' to '0.37.0-dev4' * Fix _version * Auto update version from '0.37.0-dev6' to '0.37.0-dev7' * Update format * trigger ci --------- Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPhasein favour ofCPhaseShiftin Lightning devices. qml.CPhase is an alias forqml.ControlledPhaseShiftand can be removed from the the list of supported ops and toml files.[sc-62667]
[sc-58634]