-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor of dev prerelease auto-update-version workflow #685
Conversation
Hello. You may have forgotten to update the changelog!
|
b8a898e
to
b44aaa8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rashidnhm
Just a few quick questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🥳
… condition to skip push if the output of both match
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rashidnhm
No further issues from my end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rashidnhm 💯
Context: Changes to the update_dev_version.yml
Description of the Change:
This PR introduces the following changes to the
update_dev_version.yml
workflow:dev_version_script.py
to use python-semverExample of this in action:
0.36.0-dev29
0.36.0-dev25
(Simulates someone accidentally drifting away from the master version by more than 1)With the previous version of the workflow, the pr would get auto updated to:
0.36.0-dev26
. This is technically invalid as that version already exists. Though it can be caught during manual PR review it might get by as well.With the new workflow, the pr would get auto updated to:
0.36.0-dev30
.update_dev_version.yml
to run onpull_request_target
Other notable changes:
Benefits:
Noted in the section above.
Possible Drawbacks:
With CI triggering itself, there is always a possibility CI recursively calling itself infinitely. The base case here is if the version matches what is expected, then nothing is pushed to the PR.
Related GitHub Issues:
None. sc-61382