Re-add dispatch table #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
=======================================
Coverage 62.80% 62.80%
=======================================
Files 5 5
Lines 121 121
=======================================
Hits 76 76
Misses 45 45 Continue to review full report at Codecov.
|
antalszava
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
Looks good to me! 💯 Thanks for resubmitting @ThomasLoke! 🙂
Could you also update the changelog file by adding a small description for #57 and this PR and adding yourself as a contributor to the latest release? 🙂
antalszava
reviewed
Mar 1, 2021
Comment on lines
+9
to
+23
| * Add new lightweight backend with performance improvements | ||
| [(#57)](https://github.com/PennyLaneAI/pennylane-lightning/pull/57) | ||
|
|
||
| ### Documentation | ||
|
|
||
| ### Bug fixes | ||
|
|
||
| * Re-add dispatch table after fixing static initialisation order issue | ||
| [(#68)](https://github.com/PennyLaneAI/pennylane-lightning/pull/68) | ||
|
|
||
| ### Contributors | ||
|
|
||
| This release contains contributions from (in alphabetical order): | ||
|
|
||
| Thomas Loke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm guessing that the problem was the static initialisation order not being guaranteed in different translation units, so I've just merged the two translation units.