Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ENABLE_LAPACK #678

Merged
merged 20 commits into from
Apr 24, 2024
Merged

Add ENABLE_LAPACK #678

merged 20 commits into from
Apr 24, 2024

Conversation

maliasadi
Copy link
Member

@maliasadi maliasadi commented Apr 12, 2024

[sc-61508]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (4a08cdf) to head (61307bb).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #678      +/-   ##
==========================================
+ Coverage   98.67%   98.69%   +0.01%     
==========================================
  Files         174      174              
  Lines       22629    22599      -30     
==========================================
- Hits        22330    22303      -27     
+ Misses        299      296       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maliasadi maliasadi added the ci:build_wheels Activate wheel building. label Apr 12, 2024
@maliasadi maliasadi removed the ci:build_wheels Activate wheel building. label Apr 12, 2024
@maliasadi maliasadi added the ci:build_wheels Activate wheel building. label Apr 23, 2024
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maliasadi! Looks good to me!

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Thanks!

@maliasadi maliasadi merged commit 72da7e1 into master Apr 24, 2024
81 checks passed
@maliasadi maliasadi deleted the maa/enable_lapack_macro branch April 24, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants