Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor lightning_gpu_utils unit tests to remove the dependency on statevector class #675

Merged
merged 7 commits into from
Apr 12, 2024

Conversation

multiphaseCFD
Copy link
Member

@multiphaseCFD multiphaseCFD commented Apr 11, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Refactor lightning_gpu_utils unit tests

Description of the Change:

Unit tests for sparseMV and sparseMVMPI relied on the DataBuffer class instead ofStateVectorCudaManaged and StateVectorCudaManagedMPI.

Benefits:

It will make the lightning_gpu_utils an independent module, which can be used for both cutensornet and custatevec backends after moving it to /src/utils/.

Possible Drawbacks:

Related GitHub Issues:

@multiphaseCFD multiphaseCFD added the ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request label Apr 11, 2024
@multiphaseCFD multiphaseCFD marked this pull request as ready for review April 11, 2024 13:13
@multiphaseCFD multiphaseCFD changed the title Remove StateVectorCudaManaged/MPI dependency for lightning_gpu_utils tests Refactor lightning_gpu_utils unit tests to remove the dependency on statevector class Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.10%. Comparing base (c6a8260) to head (f4b611e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #675      +/-   ##
==========================================
+ Coverage   98.99%   99.10%   +0.10%     
==========================================
  Files         173      207      +34     
  Lines       24399    29804    +5405     
==========================================
+ Hits        24155    29537    +5382     
- Misses        244      267      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@multiphaseCFD multiphaseCFD requested a review from a team April 11, 2024 14:50
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @multiphaseCFD ! Don't forget to add the ci::build_wheels label before merging.

@multiphaseCFD multiphaseCFD added the ci:build_wheels Activate wheel building. label Apr 11, 2024
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

.github/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
@multiphaseCFD multiphaseCFD merged commit 8ee3e00 into master Apr 12, 2024
85 checks passed
@multiphaseCFD multiphaseCFD deleted the clean_LGPU_utils_test branch April 12, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building. ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants