-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor lightning_gpu_utils unit tests to remove the dependency on statevector class #675
Conversation
…I/pennylane-lightning into clean_LGPU_utils_test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #675 +/- ##
==========================================
+ Coverage 98.99% 99.10% +0.10%
==========================================
Files 173 207 +34
Lines 24399 29804 +5405
==========================================
+ Hits 24155 29537 +5382
- Misses 244 267 +23 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @multiphaseCFD ! Don't forget to add the ci::build_wheels
label before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Refactor lightning_gpu_utils unit tests
Description of the Change:
Unit tests for
sparseMV
andsparseMVMPI
relied on theDataBuffer
class instead ofStateVectorCudaManaged
andStateVectorCudaManagedMPI
.Benefits:
It will make the lightning_gpu_utils an independent module, which can be used for both
cutensornet
andcustatevec
backends after moving it to/src/utils/
.Possible Drawbacks:
Related GitHub Issues: