Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment triggers. #662

Merged
merged 6 commits into from
Mar 26, 2024
Merged

Conversation

vincentmr
Copy link
Contributor

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@vincentmr vincentmr added the ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request label Mar 26, 2024
@vincentmr vincentmr marked this pull request as ready for review March 26, 2024 21:23
@vincentmr vincentmr merged commit 92e1203 into feature/linear-combination Mar 26, 2024
26 of 27 checks passed
@vincentmr vincentmr deleted the bugfix/gpu_mpi_tests branch March 26, 2024 21:23
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

mudit2812 added a commit that referenced this pull request Mar 27, 2024
* update jax config import

* Auto update version

* trigger CI

* update state vector class and tests for improved coverage

* update measurement class tests

* update dev version

* add cpp binary available variable

* remove device definition

* update dev version

* Auto update version

* reduce dependency on DefaultQubit for tests

* update LightningQubit2

* clean test_measurements_class.py

* isort+black

* review suggestion

* fix docs

* Add qml.var support.

* Add probs support.

* increase tolerance

* Auto update version

* isort

* Add double-obs tests.

* Pin pytest version (#624)

* update dev version

* update changelog

* pin pytest version in requirement files

* add a requirements file for tests against Pennylane master

* update wheels' workflows

* Version Bump (#626)

* post release version bump

* trigger CI

---------

Co-authored-by: AmintorDusko <AmintorDusko@users.noreply.github.com>
Co-authored-by: AmintorDusko <amintor_dusko@hotmail.com>

* increase tolerance

* Introduce isort. (#623)

* Introduce isort.

* Auto update version

* Update changelog

* Auto update version

* Update changelog.

* trigger ci

---------

Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com>

* Auto update version

* isort

* Add qml.var support.

* Add probs support.

* Add measurement tests with wires.

* review suggestions

* remove unused imports

* Introduce _new_API and fix/skip few tests.

* Fix few more tests.

* Skip shots, adjoint, vjp with new API.

* remove diagonalization gate application from state vector

* pytest.skip tests

* Auto update version

* Fix format

* Fix no-bin interface.

* WIP

* Initial shots support + fix test_measurement tests.

* update

* adding tests from add-simulate branch

* merge conflicts

* create state vector on initialization

* remove import of modifier from lightning

* Update pennylane_lightning/lightning_qubit/lightning_qubit2.py

* minor test updates

* register with setup.py, state vector fixes

* add LightningQubit2 to init and format

* add cpp binary available variable

* reduce dependency on DefaultQubit for tests

* update LightningQubit2

* Fixing rebase artifacts

* Add fewLQ2 tests.

* remove adjoint diff support from supports derivatives

* Remove print from test_apply

* Add expval/var tests.

* Remove duplicate class data.

* Include LQ2 in linux ests.

* Add _group_measurements support.

* --cov-append

* Add mcmc capability + tests.

* Auto update version

* update dev version

* add LightningAdjointJacobian class

* add unit tests for the LightningAdjointJacobian class

* format

* add changelog for PR #613

* [skip ci] Added skeleton file for LQ2 unit tests

* update changelog

* update adjoint Jacobian

* Auto update version

* codefactor

* Add shots tests and fix bugs in LQ, LQ2.

* Lightning qubit2 upgrade api (#628)

* update

* adding tests from add-simulate branch

* merge conflicts

* create state vector on initialization

* remove import of modifier from lightning

* Update pennylane_lightning/lightning_qubit/lightning_qubit2.py

* minor test updates

* register with setup.py, state vector fixes

* add LightningQubit2 to init and format

* add cpp binary available variable

* Auto update version

* reduce dependency on DefaultQubit for tests

* update LightningQubit2

* Introduce _new_API and fix/skip few tests.

* Fix few more tests.

* Skip shots, adjoint, vjp with new API.

* Fix no-bin interface.

* Remove duplicate class data.

* Include LQ2 in linux ests.

* --cov-append

---------

Co-authored-by: albi3ro <chrissie.c.l@gmail.com>
Co-authored-by: AmintorDusko <amintor_dusko@hotmail.com>
Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com>

* fix processing_fn_expval

* make a proper new_tape

* Added init tests; Added skeleton tests for helpers

* Fix more bug with shots.

* trigger CI

* Change pennylane branch for CI.

* Update .github/CHANGELOG.md

Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>

* Update pennylane_lightning/lightning_qubit/_adjoint_jacobian.py

Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>

* Update pennylane_lightning/lightning_qubit/_adjoint_jacobian.py

Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>

* Add probs support.

* Add double-obs tests.

* Add qml.var support.

* Add probs support.

* Add measurement tests with wires.

* pytest.skip tests

* Fix format

* update

* adding tests from add-simulate branch

* merge conflicts

* create state vector on initialization

* remove import of modifier from lightning

* Update pennylane_lightning/lightning_qubit/lightning_qubit2.py

* minor test updates

* register with setup.py, state vector fixes

* add LightningQubit2 to init and format

* add cpp binary available variable

* reduce dependency on DefaultQubit for tests

* update LightningQubit2

* Fixing rebase artifacts

* remove adjoint diff support from supports derivatives

* [skip ci] Added skeleton file for LQ2 unit tests

* Lightning qubit2 upgrade api (#628)

* update

* adding tests from add-simulate branch

* merge conflicts

* create state vector on initialization

* remove import of modifier from lightning

* Update pennylane_lightning/lightning_qubit/lightning_qubit2.py

* minor test updates

* register with setup.py, state vector fixes

* add LightningQubit2 to init and format

* add cpp binary available variable

* Auto update version

* reduce dependency on DefaultQubit for tests

* update LightningQubit2

* Introduce _new_API and fix/skip few tests.

* Fix few more tests.

* Skip shots, adjoint, vjp with new API.

* Fix no-bin interface.

* Remove duplicate class data.

* Include LQ2 in linux ests.

* --cov-append

---------

Co-authored-by: albi3ro <chrissie.c.l@gmail.com>
Co-authored-by: AmintorDusko <amintor_dusko@hotmail.com>
Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com>

* Added init tests; Added skeleton tests for helpers

* Resolving rebase artifacts

* Refactor shots test.

* Added tests; integrated jacobian

* Update pennylane_lightning/lightning_qubit/lightning_qubit2.py

Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>

* Auto update version

* Small update to simulate_and_jacobian

* Auto update version

* Rerun isort.

* Uncomment integration tests.

* Reformat

* Delete symlink

* Fix pylint.

* Run linux tests in parallel (when possible).

* Run double obs tests with shots.

* Revert linux tests

* Fix bg in diag_gates.

* Call isort/black with python -m

* update dev version

* Add docstrings, rm C_DTYPE.

* Auto update version

* comment isort check

* trigger ci

* Update tests/test_expval.py

Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>

* Init mcmc params to None in measurements.

* Reformat with python3.11

* Reformat black

* Auto update version

* update QuantumScriptSerializer

* remove LightningQubit2 from init

* update setup.py

* remove lightning.qubit2 from tests configuration

* remove extra tests for lightning.qubit2

* migrate lightning.qubit2 to lightning.qubit on tests

* make lightning.qubit2 the new lightning.qubit

* add device name (necessary for pl-device-test)

* Add _measure_hamiltonian_with_samples _measure_sum_with_samples

* fix tests without binary

* check for jac size before reshaping

* remove obsolete tests

* organize tests

* fix test for Windows wheels

* Adding LC to supported obs list for all devices

* Updating serialization

* Trying out test changes

* Updated PL dependency

* Running isort

* Update CPP layer for observable accessible functions

* Auto update version

* Allow output from  TP CPP layer

* Fixed serialize tests

* Added legacy fixture to failing tests

* Updated requirements with debug branch

* Trigger CI

* Auto update version

* Trigger CI

* Trigger CI

* Added recursive logic to find projectors

* format

* mark tests to be dual tested and some small fixes

* example of test failing

* remove print and move ham to tape scope

* Fixed expval test; isort

* Auto update version

* isort

* Updated device tests; changelog entry

* Update mpitests/test_apply.py

* Auto update version

* Fix terms in ham serialization.

* Use requirements-dev.txt to install black/isort.

* Mark test_single_return_value flaky. Add comment on split_obs.

* Apply suggestions from code review

Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>

* Auto update version

* Auto update version

* Trigger CI

* Fix format

* Updated PL branch in reqs-dev

* Update requirements

* Added fix for prod with overlapping wires

* Formatting

* Point requirements to PL master

* Pinning cmake

* Pinned cmake in workflows

* Pinned cmake in more workflows

* Trigger CI

* Apply suggestions from code review

Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>

* [skip ci] Apply suggestions from code review

Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>

* Trigger CI

* Fix indent.

* Fix workflow files indentation

* Comment triggers. (#662)

* Comment triggers.

* pytest -x

* trigger ci

* Do not skip comp for LQ.

* Revert triggers

* Revert changes

---------

Co-authored-by: AmintorDusko <amintor_dusko@hotmail.com>
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Vincent Michaud-Rioux <vincent.michaud-rioux@xanadu.ai>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: AmintorDusko <AmintorDusko@users.noreply.github.com>
Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>
Co-authored-by: albi3ro <chrissie.c.l@gmail.com>
Co-authored-by: Lee J. O'Riordan <loriordan@gmail.com>
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Co-authored-by: Lee James O'Riordan <mlxd@users.noreply.github.com>
multiphaseCFD added a commit that referenced this pull request Apr 9, 2024
* comment isort check

* trigger ci

* Update tests/test_expval.py

Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>

* Init mcmc params to None in measurements.

* Reformat with python3.11

* Reformat black

* Auto update version

* update QuantumScriptSerializer

* remove LightningQubit2 from init

* update setup.py

* remove lightning.qubit2 from tests configuration

* remove extra tests for lightning.qubit2

* migrate lightning.qubit2 to lightning.qubit on tests

* make lightning.qubit2 the new lightning.qubit

* add device name (necessary for pl-device-test)

* Add _measure_hamiltonian_with_samples _measure_sum_with_samples

* fix tests without binary

* check for jac size before reshaping

* remove obsolete tests

* organize tests

* fix test for Windows wheels

* Adding LC to supported obs list for all devices

* Updating serialization

* Trying out test changes

* Updated PL dependency

* Running isort

* Update CPP layer for observable accessible functions

* Auto update version

* Allow output from  TP CPP layer

* initial commit

* Fixed serialize tests

* fix windows ci

* Added legacy fixture to failing tests

* Updated requirements with debug branch

* Trigger CI

* Auto update version

* Trigger CI

* Trigger CI

* add priority table for scipy.libs loading

* add filesytem header

* fix libLoad for linux

* Added recursive logic to find projectors

* format

* mark tests to be dual tested and some small fixes

* example of test failing

* remove print and move ham to tape scope

* fix currentPath -> current_path

* fix for windows scipy libs iteration

* windows fix

* Fixed expval test; isort

* Auto update version

* fix windows

* quick fix

* std::filesystem::path::value_type*  LPCSTR convert

* windows type convert

* isort

* Updated device tests; changelog entry

* get current path of dso with dlfcn apis

* quick fix

* Update mpitests/test_apply.py

* Auto update version

* Fix terms in ham serialization.

* Use requirements-dev.txt to install black/isort.

* Mark test_single_return_value flaky. Add comment on split_obs.

* add sharedLibLoader wrapper class

* fix typo

* fix typo

* remove vcpkg dependence

* windows workflow test

* windows yaml test

* windows yaml test

* echo pythonSitePackages

* Apply suggestions from code review

Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>

* Auto update version

* windows.yaml tests

* check child directory of site-packages

* quick fix

* fix typo

* set python site-packages with cmake

* remove package_site env set from windows.yml

* fix cmake package_sites get

* check Python_SITELIB variable

* check if env is correctly set

* install scipy with linux cpp test

* use config file to pass path scipy to cpp layer

* remove liblapack_dev install in ci work flows

* Auto update version

* Trigger CI

* fix typo of path to scipy in windows with cmake

* fix for linux ci

* install python and scipy for window cpp tests

* debug windows path

* test for windows

* remove iostream in UtilLinearAlg.hpp

* add specific scipy lib path for windows

* replace \ with / in windows

* use cmake string replace to replace backslash

* tidy up code

* codeFactor [skip] & add more win32 cpp tests

* add noinspection CodeFactor

* codefactor[skip] for LoadLibrary

* install scipy with the py cmake can access

* tidy up code

* codefactor warning suppress

* cmake call avail python to get sites_package

* test

* debug windows

* strip traling whitespace execute_process

* suppress compile time check warning

* fix typo

* install scipy into local usr package sites

* get scipy path directly instead of site-packages

* add python_sitelib for scipy search

* Trigger CI

* add scipy dependency for wheel building

* test for win wheel build

* windows wheel fix test

* install scipy with cmake

* win wheels

* fix multiple python version in win wheels build

* debug win wheels build

* abs path search for cpp backend, rpath for python

* quick fix

* quick fix

* lapack path info stored in config.hpp for macos

* add a dummy config.h

* fix getPath

* Auto update version

* Trigger CI

* Fix format

* get scipy path from env variable

* Auto update version

* quick fix

* debug windows

* quick test

* debug getenv

* Updated PL branch in reqs-dev

* debug python

* debug

* Update requirements

* fix workflow

* debug

* debug

* use absoute path for file exists check

* link against dl

* test

* Added fix for prod with overlapping wires

* Formatting

* test with -rdynamic

* link against dl

* revert to get scipylibs with config.h.in

* windows fix

* setup win wheels build venv with CIBW_BEFORE_ALL

* fix for windows wheel build

* activate venv before windows wheels build

* quick fix

* quick fix win wheels

* quick fix for win wheel build

* add scipy to requirements

* runtime load in relative path fix test

* remove scipy from requirements in setup.py

* add inline to fix compile time

* Point requirements to PL master

* support both rpath and SCIPY_LIBS_PATH search

* Pinning cmake

* add lapack.so search in default search path

* make format

* quick fix

* quick fix

* install lapack

* quick fix

* Pinned cmake in workflows

* Pinned cmake in more workflows

* Trigger CI

* quick tests

* quick fix

* quick fix

* Apply suggestions from code review

Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>

* quickfix

* [skip ci] Apply suggestions from code review

Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>

* Trigger CI

* update sharedlibloader

* remove canonical file

* install scipy linux ci

* Fix indent.

* Fix workflow files indentation

* Comment triggers. (#662)

* Comment triggers.

* pytest -x

* trigger ci

* Do not skip comp for LQ.

* Revert triggers

* Revert changes

* add pragma onceguard

* quick test

* remove tests on win32

* make format

* tidy up code

* use absolute path for scipy.libs

* Auto update version

* fix typo

* test for lapack is not available

* remove lapack from gpu tests

* parse string to get scipy.libs in site-pack

* use scipy.libs only for lapack apis

* tidy up code

* update docs and add changelog

* make format

* tidy up code

* exclude macos code blocks from codecov

* Auto update version

* make format

* Update CMake and remove config.h

* Update SharedLibLoader: add dlfcn macros and simplify the dlopen mode

* Update UtilLinearAlg.hpp: use an array instead of map for the priority-table and remove std::sort from the logic by re-ordering lookups

* Add support for clang

* Auto update version

* add conda search path

* tidy up code

* Auto update version

* Triger CI

* tidy up mpi tests

* Auto update version

* Triger CI

* test mgpu

* Turn on all tests

---------

Co-authored-by: AmintorDusko <amintor_dusko@hotmail.com>
Co-authored-by: Vincent Michaud-Rioux <vincent.michaud-rioux@xanadu.ai>
Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Co-authored-by: Lee J. O'Riordan <loriordan@gmail.com>
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Co-authored-by: Lee James O'Riordan <mlxd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant