Fix state prep operation decomposition with LightningQubit
#661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maliasadi
reviewed
Mar 22, 2024
|
This is related to PR PennyLaneAI/pennylane#5434. |
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #661 +/- ##
===========================================
+ Coverage 53.58% 98.69% +45.10%
===========================================
Files 13 172 +159
Lines 1950 24345 +22395
===========================================
+ Hits 1045 24027 +22982
+ Misses 905 318 -587 ☔ View full report in Codecov by Sentry. |
vincentmr
approved these changes
Mar 22, 2024
AmintorDusko
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Bunch of test failures in CI are related to
lightning.qubitnot working with adjoint diff whenever there are state prep operations present, even then they're not supposed to be trainable.Description of the Change:
Update the adjoint diff validation for
lightning.qubitto decompose state prep operations.Benefits:
Better support for adjoint with
lightning.qubit.Possible Drawbacks:
Related GitHub Issues: