Add MidMeasureMP Kokkos #658

tomlqc · 2024-03-21T20:01:12Z

Before submitting

Please complete the following checklist when submitting a PR:

All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests directory!
All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running make docs.
Ensure that the test suite passes, by running make test.
Add a new entry to the .github/CHANGELOG.md file, summarizing the
change, and including a link back to the PR.
Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

Context:
Same as #621 for Lightning-Kokkos

Description of the Change:

Add method to obtain the probability in the z-basis on a given wire.
Add RNG attribute.
Add method to init the RNG attribute with a given seed.
Add method to sample from a binomial distribution.
Add method to collapse the state vector onto a given branch.
Add method which implements the MidMeasureMP workflow.
Add bindings to the MidMeasureMP method.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Related Shortcut Story:
[sc-58334]
[sc-60946]

pennylane_lightning/core/src/utils/TestHelpers.hpp

tomlqc · 2024-03-22T12:51:42Z

@vincentmr you may have a look on the C++ implementation, especially about the functor for Kokkos. I'll add the bindings later.

pennylane_lightning/core/src/simulators/lightning_kokkos/gates/GateFunctorsGenerator.hpp

pennylane_lightning/core/src/simulators/lightning_kokkos/StateVectorKokkos.hpp

…-kokkos

* Add MCM bindings and tests for L-Kokkos. * Auto update version * Refactor collapse. * Try parallelizing tests. * Only run test_native_mcm once amongst all workflows since it takes quite a bit of time. * trigger ci --------- Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com>

.github/workflows/tests_gpu_cuda.yml

.github/workflows/tests_gpu_kokkos.yml

.github/workflows/tests_linux.yml

pennylane_lightning/core/src/simulators/lightning_kokkos/measurements/MeasurementsKokkos.hpp

tests/test_native_mcm.py

codecov · 2024-04-10T13:08:01Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.12%. Comparing base (2028317) to head (e4f0716).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
+ Coverage   90.91%   97.12%   +6.20%     
==========================================
  Files          64      150      +86     
  Lines        9243    19515   +10272     
==========================================
+ Hits         8403    18953   +10550     
+ Misses        840      562     -278

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

maliasadi

Nice work!

pennylane_lightning/core/src/simulators/lightning_kokkos/StateVectorKokkos.hpp

pennylane_lightning/core/src/simulators/lightning_kokkos/bindings/LKokkosBindings.hpp

pennylane_lightning/core/src/simulators/lightning_kokkos/tests/Test_StateVectorLKokkos.cpp

pennylane_lightning/lightning_kokkos/lightning_kokkos.py

…ngs/LKokkosBindings.hpp Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>

…VectorKokkos.hpp Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>

…he device but not Catalyst.

maliasadi

Thanks fellas! 💯

AmintorDusko

Nice job!

pennylane_lightning/core/src/simulators/lightning_kokkos/StateVectorKokkos.hpp

pennylane_lightning/core/src/simulators/lightning_kokkos/tests/Test_StateVectorLKokkos.cpp

…/Test_StateVectorLKokkos.cpp Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>

…VectorKokkos.hpp Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>

vincentmr · 2024-04-12T18:14:05Z

Nice job!

Thanks for the suggestions @AmintorDusko .

* collapse() and normalized() with Kokkos * Auto update version * CodeFactor * normalize() abort if norm is zero * unittest for normalize() * Auto update version * unittest for normalize() in LighningQubit * Auto update version * Add MCM bindings and tests for L-Kokkos. (#672) * Add MCM bindings and tests for L-Kokkos. * Auto update version * Refactor collapse. * Try parallelizing tests. * Only run test_native_mcm once amongst all workflows since it takes quite a bit of time. * trigger ci --------- Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com> * Do not run test_native_mcm with LK-GPU. * Auto update version * trigger ci * Update pennylane_lightning/core/src/simulators/lightning_kokkos/bindings/LKokkosBindings.hpp Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com> * Auto update version * Update pennylane_lightning/core/src/simulators/lightning_kokkos/StateVectorKokkos.hpp Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com> * Update pennylane_lightning/core/src/simulators/lightning_kokkos/StateVectorKokkos.hpp Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com> * Update pennylane_lightning/core/src/simulators/lightning_kokkos/StateVectorKokkos.hpp Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com> * Update pennylane_lightning/core/src/simulators/lightning_kokkos/StateVectorKokkos.hpp Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com> * Increase shotsfor flaky test_composite_mcm_single_measure_obs * Create separate device_allowed_operations list for ops supported by the device but not Catalyst. * Use isinstance instead of name comparison. * Check projector. * Update operations at device init. * Modify stopping condition in LK. * Cannot use instance with Hamiltonian check. * Update pennylane_lightning/core/src/simulators/lightning_kokkos/tests/Test_StateVectorLKokkos.cpp Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com> * Update pennylane_lightning/core/src/simulators/lightning_kokkos/StateVectorKokkos.hpp Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com> * Remove obsolete comment. * Auto update version * trigger ci --------- Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com> Co-authored-by: Vincent Michaud-Rioux <vincent.michaud-rioux@xanadu.ai> Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com> Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com> Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>

* Init commit * Auto update version * Add MidMeasureMP Kokkos (#658) * collapse() and normalized() with Kokkos * Auto update version * CodeFactor * normalize() abort if norm is zero * unittest for normalize() * Auto update version * unittest for normalize() in LighningQubit * Auto update version * Add MCM bindings and tests for L-Kokkos. (#672) * Add MCM bindings and tests for L-Kokkos. * Auto update version * Refactor collapse. * Try parallelizing tests. * Only run test_native_mcm once amongst all workflows since it takes quite a bit of time. * trigger ci --------- Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com> * Do not run test_native_mcm with LK-GPU. * Auto update version * trigger ci * Update pennylane_lightning/core/src/simulators/lightning_kokkos/bindings/LKokkosBindings.hpp Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com> * Auto update version * Update pennylane_lightning/core/src/simulators/lightning_kokkos/StateVectorKokkos.hpp Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com> * Update pennylane_lightning/core/src/simulators/lightning_kokkos/StateVectorKokkos.hpp Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com> * Update pennylane_lightning/core/src/simulators/lightning_kokkos/StateVectorKokkos.hpp Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com> * Update pennylane_lightning/core/src/simulators/lightning_kokkos/StateVectorKokkos.hpp Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com> * Increase shotsfor flaky test_composite_mcm_single_measure_obs * Create separate device_allowed_operations list for ops supported by the device but not Catalyst. * Use isinstance instead of name comparison. * Check projector. * Update operations at device init. * Modify stopping condition in LK. * Cannot use instance with Hamiltonian check. * Update pennylane_lightning/core/src/simulators/lightning_kokkos/tests/Test_StateVectorLKokkos.cpp Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com> * Update pennylane_lightning/core/src/simulators/lightning_kokkos/StateVectorKokkos.hpp Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com> * Remove obsolete comment. * Auto update version * trigger ci --------- Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com> Co-authored-by: Vincent Michaud-Rioux <vincent.michaud-rioux@xanadu.ai> Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com> Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com> Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com> * Trigger CI * make format * Auto update version * Trigger CIs * Auto update version * Trigger CI * Auto update version * add more docstring * add changelog * Update pennylane_lightning/core/src/simulators/lightning_gpu/utils/cuStateVecError.hpp Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com> * Update pennylane_lightning/core/src/simulators/lightning_gpu/utils/cuStateVecError.hpp Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com> * Update pennylane_lightning/core/src/simulators/lightning_gpu/utils/cuStateVec_helpers.hpp Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com> * Update pennylane_lightning/core/src/simulators/lightning_gpu/utils/cuStateVecError.hpp Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com> * Update pennylane_lightning/core/src/simulators/lightning_gpu/utils/cuStateVec_helpers.hpp Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com> * Update pennylane_lightning/core/src/simulators/lightning_gpu/utils/cuStateVec_helpers.hpp Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com> * Update pennylane_lightning/core/src/utils/cuda_utils/cuError.hpp Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com> * Update pennylane_lightning/core/src/simulators/lightning_gpu/utils/cuStateVecError.hpp Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com> * Trigger CI * make format * quick fix * fix --------- Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com> Co-authored-by: Thomas Germain <115888357+tomlqc@users.noreply.github.com> Co-authored-by: Vincent Michaud-Rioux <vincent.michaud-rioux@xanadu.ai> Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com> Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com> Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>

tomlqc and others added 2 commits March 21, 2024 15:53

collapse() and normalized() with Kokkos

174addc

Auto update version

6da13fb

tomlqc commented Mar 21, 2024

View reviewed changes

pennylane_lightning/core/src/utils/TestHelpers.hpp Show resolved Hide resolved

tomlqc and others added 5 commits March 21, 2024 16:14

CodeFactor

4cecf3e

normalize() abort if norm is zero

e54f06f

unittest for normalize()

6c2bb9d

Auto update version

e06ded6

unittest for normalize() in LighningQubit

694a62c

tomlqc requested a review from vincentmr March 22, 2024 12:49

vincentmr reviewed Mar 22, 2024

View reviewed changes

pennylane_lightning/core/src/simulators/lightning_kokkos/gates/GateFunctorsGenerator.hpp Outdated Show resolved Hide resolved

vincentmr reviewed Mar 22, 2024

View reviewed changes

pennylane_lightning/core/src/simulators/lightning_kokkos/StateVectorKokkos.hpp Outdated Show resolved Hide resolved

vincentmr reviewed Mar 22, 2024

View reviewed changes

pennylane_lightning/core/src/simulators/lightning_kokkos/StateVectorKokkos.hpp Outdated Show resolved Hide resolved

vincentmr and others added 4 commits April 4, 2024 20:46

Merge remote-tracking branch 'origin/master' into feature/mid-measure…

30e51b9

…-kokkos

Auto update version

31bc86f

Merge branch 'master' into feature/mid-measure-kokkos

4bff4e5

vincentmr reviewed Apr 10, 2024

View reviewed changes

vincentmr marked this pull request as ready for review April 10, 2024 13:52

vincentmr added the ci:build_wheels Activate wheel building. label Apr 10, 2024

vincentmr and others added 4 commits April 10, 2024 18:43

Do not run test_native_mcm with LK-GPU.

8e4030b

Merge branch 'master' into feature/mid-measure-kokkos

d454a57

Auto update version

dff080a

trigger ci

2e2a146

vincentmr requested a review from a team April 11, 2024 13:35

maliasadi reviewed Apr 12, 2024

View reviewed changes

vincentmr and others added 3 commits April 12, 2024 09:04

Update pennylane_lightning/core/src/simulators/lightning_kokkos/bindi…

a9564a4

…ngs/LKokkosBindings.hpp Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>

Auto update version

6996858

Merge branch 'master' into feature/mid-measure-kokkos

5ac112c

vincentmr and others added 11 commits April 12, 2024 10:58

Update pennylane_lightning/core/src/simulators/lightning_kokkos/State…

fb35dd2

…VectorKokkos.hpp Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>

Update pennylane_lightning/core/src/simulators/lightning_kokkos/State…

b551e19

…VectorKokkos.hpp Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>

Update pennylane_lightning/core/src/simulators/lightning_kokkos/State…

b236550

…VectorKokkos.hpp Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>

Update pennylane_lightning/core/src/simulators/lightning_kokkos/State…

be8a264

…VectorKokkos.hpp Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>

Increase shotsfor flaky test_composite_mcm_single_measure_obs

dc7ddd5

Create separate device_allowed_operations list for ops supported by t…

2395097

…he device but not Catalyst.

Use isinstance instead of name comparison.

fbba18a

Check projector.

e5c2a8e

Update operations at device init.

e5fd200

Modify stopping condition in LK.

193a279

Cannot use instance with Hamiltonian check.

84ea17b

maliasadi approved these changes Apr 12, 2024

View reviewed changes

AmintorDusko approved these changes Apr 12, 2024

View reviewed changes

vincentmr and others added 3 commits April 12, 2024 14:11

Update pennylane_lightning/core/src/simulators/lightning_kokkos/tests…

dc5d848

…/Test_StateVectorLKokkos.cpp Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>

Update pennylane_lightning/core/src/simulators/lightning_kokkos/State…

098ca7e

…VectorKokkos.hpp Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>

Remove obsolete comment.

121d403

vincentmr and others added 3 commits April 12, 2024 14:39

Merge branch 'master' into feature/mid-measure-kokkos

f2f3e33

Auto update version

bfc7b6c

trigger ci

e4f0716

vincentmr merged commit d0e1c51 into master Apr 12, 2024
83 checks passed

vincentmr deleted the feature/mid-measure-kokkos branch April 12, 2024 20:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add MidMeasureMP Kokkos #658

Add MidMeasureMP Kokkos #658

tomlqc commented Mar 21, 2024 •

edited by vincentmr

Loading

tomlqc commented Mar 22, 2024 •

edited

Loading

codecov bot commented Apr 10, 2024 •

edited

Loading

maliasadi left a comment

maliasadi left a comment

AmintorDusko left a comment

vincentmr commented Apr 12, 2024

Add MidMeasureMP Kokkos #658

Add MidMeasureMP Kokkos #658

Conversation

tomlqc commented Mar 21, 2024 • edited by vincentmr Loading

Before submitting

tomlqc commented Mar 22, 2024 • edited Loading

codecov bot commented Apr 10, 2024 • edited Loading

Codecov Report

maliasadi left a comment

Choose a reason for hiding this comment

maliasadi left a comment

Choose a reason for hiding this comment

AmintorDusko left a comment

Choose a reason for hiding this comment

vincentmr commented Apr 12, 2024

tomlqc commented Mar 21, 2024 •

edited by vincentmr

Loading

tomlqc commented Mar 22, 2024 •

edited

Loading

codecov bot commented Apr 10, 2024 •

edited

Loading