Fix stopping condition thresholds

[mlxd]

Before submitting

Please complete the following checklist when submitting a PR:

• All new features must include a unit test.
  If you've fixed a bug or added code that should be tested, add a test to the
  tests directory!

• All new functions and code must be clearly commented and documented.
  If you do make documentation changes, make sure that the docs build and
  render correctly by running make docs.

• Ensure that the test suite passes, by running make test.

• Add a new entry to the .github/CHANGELOG.md file, summarizing the
  change, and including a link back to the PR.

• Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

---

Context: This fixes the matrix vs decomposition split in the stopping condition for the included aggregate template operations.

Description of the Change: Avoids building matrices beyond the given thresholds defined in the stopping condition.

Benefits: Significantly reduced runtime overheads for larger systems.

Possible Drawbacks:

Related GitHub Issues:

[mlxd]

[sc-56165]

[AmintorDusko]

Thank you for the fix. Could you please add tests that cover the previously wrong behavior?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f3beabc) 98.48% compared to head (3828046) 98.65%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #609      +/-   ##
==========================================
+ Coverage   98.48%   98.65%   +0.16%     
==========================================
  Files         169      169              
  Lines       24760    24344     -416     
==========================================
- Hits        24386    24017     -369     
+ Misses        374      327      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mlxd]

Thank you for the fix. Could you please add tests that cover the previously wrong behavior?

Done. The old test was relying on qubit_device provided functionality, rather than the (uninstantiated) L devices. The test change will catch this, at the expense of a reasonable qubit count allocation,

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3527765) 96.79% compared to head (cbd8c2d) 96.79%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #609   +/-   ##
=======================================
  Coverage   96.79%   96.79%           
=======================================
  Files         169      169           
  Lines       24294    24296    +2     
=======================================
+ Hits        23516    23518    +2     
  Misses        778      778           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vincentmr]

Looks good to me, thanks @mlxd .

[AmintorDusko]

Hey @mlxd, nice work! Please re-tag me when CIs are successful.

[AmintorDusko]

Looks good!