Update lightning qubit memory management #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #601 +/- ##
==========================================
+ Coverage 98.52% 98.68% +0.15%
==========================================
Files 168 169 +1
Lines 24566 24344 -222
==========================================
- Hits 24204 24023 -181
+ Misses 362 321 -41 ☔ View full report in Codecov by Sentry. |
AmintorDusko
commented
Jan 26, 2024
vincentmr
reviewed
Jan 26, 2024
pennylane_lightning/core/src/simulators/lightning_qubit/StateVectorLQubitManaged.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_qubit/StateVectorLQubitManaged.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_qubit/bindings/LQubitBindings.hpp
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_qubit/bindings/LQubitBindings.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_qubit/bindings/LQubitBindings.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_qubit/tests/Test_StateVectorLQubitManaged.cpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_qubit/tests/Test_StateVectorLQubitManaged.cpp
Show resolved
Hide resolved
vincentmr
reviewed
Jan 29, 2024
There was a problem hiding this comment.
Just a couple comments, but looking good. Thanks @AmintorDusko .
mlxd
requested changes
Jan 29, 2024
There was a problem hiding this comment.
Thanks a bunch @AmintorDusko
A few follow on questions. Also, since there seems to be a few reports from codecov about missing test-coverage, do we want to add it for these cases?
pennylane_lightning/core/src/simulators/lightning_qubit/StateVectorLQubitManaged.hpp
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_qubit/bindings/LQubitBindings.hpp
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_qubit/bindings/LQubitBindings.hpp
Show resolved
Hide resolved
Co-authored-by: Lee James O'Riordan <mlxd@users.noreply.github.com>
vincentmr
approved these changes
Jan 30, 2024
|
Observed increase in performance with a simple parameter-shift circuit: dev = qml.device("lightning.qubit", wires=n_wires)
@qml.qnode(dev, diff_method="parameter-shift")
def circuit(params):
qml.RX(params[0], wires=0)
qml.RY(params[1], wires=0)
qml.RX(params[2], wires=0)
return qml.expval(qml.PauliZ(0))
params = qnp.array([0.1, 0.2, 0.3], requires_grad=True)
qml.jacobian(circuit)(params)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change:
Update Lightning qubit memory management to LightningQubitManaged.
Related Shotcut Stories:
[sc-53796]
[sc-51664]