All tags allowed for LIGHTNING_VERSION Docker build argument.

[vincentmr]

Before submitting

Please complete the following checklist when submitting a PR:

• All new features must include a unit test.
  If you've fixed a bug or added code that should be tested, add a test to the
  tests directory!

• All new functions and code must be clearly commented and documented.
  If you do make documentation changes, make sure that the docs build and
  render correctly by running make docs.

• Ensure that the test suite passes, by running make test.

• Add a new entry to the .github/CHANGELOG.md file, summarizing the
  change, and including a link back to the PR.

• Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

---

Context:
The way our Dockerfile is setup prevent building against anything else than official releases. It can be convenient to rebuild against some branches, tags, etc. and hence this PR introduces flexibility in the LIGHTNING_VERSION build argument.

Description of the Change:
I also added a cron job building all images for master to track any regression in the Docker builds.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (415b95b) 98.96% compared to head (1f16ef2) 98.67%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #598      +/-   ##
==========================================
- Coverage   98.96%   98.67%   -0.30%     
==========================================
  Files         169      169              
  Lines       24308    24308              
==========================================
- Hits        24056    23985      -71     
- Misses        252      323      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vincentmr]

sc-55196-docker-support-allow-builds-from-any-branch

[mlxd]

Thanks @vincentmr
Nothing to add 👍

[AmintorDusko]

Thank you for that!