Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kokkos to 4.2.00 in CI (L-Kokkos-CUDA tests) #596

Merged
merged 5 commits into from
Jan 22, 2024

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Jan 19, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
The official Kokkos 4.2.00 release can now be used in the CI, and hence there is no reason to keep building against some detached commit.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c0ad27) 98.67% compared to head (f8badf4) 98.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #596   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files         169      169           
  Lines       24308    24308           
=======================================
  Hits        23985    23985           
  Misses        323      323           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentmr vincentmr marked this pull request as ready for review January 19, 2024 23:08
@vincentmr vincentmr requested a review from a team January 19, 2024 23:08
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vincentmr ! Looks good to me.

@vincentmr vincentmr changed the title Kokkos/update42 Update Kokkos to 4.2.00 in CI (L-Kokkos-CUDA tests) Jan 19, 2024
@vincentmr vincentmr requested review from doctorperceptron and a team January 22, 2024 13:30
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vincentmr vincentmr removed the request for review from doctorperceptron January 22, 2024 14:16
@vincentmr vincentmr merged commit 39cffac into master Jan 22, 2024
85 checks passed
@vincentmr vincentmr deleted the kokkos/update42 branch January 22, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants