-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MANIFEST to package toml files #585
Conversation
Hello. You may have forgotten to update the changelog!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem for me, thanks @maliasadi
Be sure to update the changelog, and see that the version string bot doesn't block the CI by retriggering the CI :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 💯
Co-authored-by: David Ittah <dime10@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #585 +/- ##
=======================================
Coverage 98.68% 98.68%
=======================================
Files 167 167
Lines 23959 23959
=======================================
Hits 23644 23644
Misses 315 315 ☔ View full report in Codecov by Sentry. |
Update
MANIFEST.in
to include deivce config files andCHANGELOG.md
[sc-52852]