Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MANIFEST to package toml files #585

Merged
merged 5 commits into from
Jan 3, 2024
Merged

Conversation

maliasadi
Copy link
Member

@maliasadi maliasadi commented Jan 3, 2024

Update MANIFEST.in to include deivce config files and CHANGELOG.md

[sc-52852]

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem for me, thanks @maliasadi
Be sure to update the changelog, and see that the version string bot doesn't block the CI by retriggering the CI :)

@maliasadi maliasadi requested a review from dime10 January 3, 2024 16:34
Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯

.github/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: David Ittah <dime10@users.noreply.github.com>
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4290e60) 98.68% compared to head (033ff5b) 98.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #585   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files         167      167           
  Lines       23959    23959           
=======================================
  Hits        23644    23644           
  Misses        315      315           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maliasadi maliasadi merged commit 44c04f1 into master Jan 3, 2024
83 checks passed
@maliasadi maliasadi deleted the maa/update-toml-path branch January 3, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants