Pass control values to the L-Qubit kernels #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #576 +/- ##
==========================================
+ Coverage 98.95% 99.08% +0.12%
==========================================
Files 167 201 +34
Lines 24382 29290 +4908
==========================================
+ Hits 24128 29021 +4893
- Misses 254 269 +15 ☔ View full report in Codecov by Sentry. |
vincentmr
added
the
ci:use-multi-gpu-runner
|
Support arbitrary controlled values in lightning [sc-51996] |
AmintorDusko
requested changes
Dec 13, 2023
pennylane_lightning/core/src/simulators/lightning_gpu/StateVectorCudaManaged.hpp
Show resolved
Hide resolved
AmintorDusko
approved these changes
Dec 13, 2023
pennylane_lightning/core/src/simulators/lightning_qubit/StateVectorLQubit.hpp
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_qubit/StateVectorLQubit.hpp
Outdated
Show resolved
Hide resolved
|
Nice job @vincentmr ! Happy to approve. A kind reminder: please make sure all CI checks passed before merge. |
multiphaseCFD
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Following up on #516 , this PR introduces
controlled_valueseverywhere to improve the flexibility of the n-control interface.Description of the Change:
Pass
controlled_valuesaround everywherecontrolled_wiresare to be found. I also remove theexterndefinitions fromGateImplementationsLM.hpp(not effect on build times AFAIK).Benefits:
Simpler decompositions for non-strictly
1-controlled gates (improved perf). For example, this is important in Grover's algorithm. While it makes no difference when searching for the111...111string (best case scenario), it makes a significant difference (~50%) when searching for the000...000string (worst case scenario). These are extreme cases, but it gives an idea. Here are some benchmarks performed on a single Perlmutter core before and after this PR.The
externdefinitions need not be maintained.Possible Drawbacks:
Increased code complexity.
Related GitHub Issues: