Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade/dockerfile v0.33 #539

Merged
merged 18 commits into from
Nov 10, 2023
Merged

Upgrade/dockerfile v0.33 #539

merged 18 commits into from
Nov 10, 2023

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Oct 31, 2023

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
L-GPU can now be built from the pennylane-lightning repo. The Dockerfile can be updated accordingly.

Description of the Change:
Update README and L-GPU build stage.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (23f9d92) 96.96% compared to head (191ffc3) 96.96%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master     #539    +/-   ##
========================================
  Coverage   96.96%   96.96%            
========================================
  Files         144      145     +1     
  Lines       17183    17323   +140     
========================================
+ Hits        16661    16798   +137     
- Misses        522      525     +3     
Files Coverage Δ
pennylane_lightning/core/_version.py 100.00% <100.00%> (ø)

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentmr vincentmr marked this pull request as ready for review October 31, 2023 17:46
@vincentmr vincentmr requested a review from a team October 31, 2023 17:46
@vincentmr vincentmr requested a review from a team October 31, 2023 21:05
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I left some suggestions.

Makefile Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
vincentmr and others added 2 commits November 10, 2023 15:13
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
@vincentmr vincentmr merged commit 7442701 into master Nov 10, 2023
75 checks passed
@vincentmr vincentmr deleted the upgrade/dockerfile_v0.33 branch November 10, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants