Add GateImplementationsLM::applyGeneratorDoubleExcitation(Minus/Plus)… #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
vincentmr
force-pushed
the
sc-47249-implement-doubleexcitation-lm-kernels
branch
from
7107a75 to
c0067fb
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #512 +/- ##
=======================================
Coverage 99.13% 99.13%
=======================================
Files 143 143
Lines 16850 16857 +7
=======================================
+ Hits 16704 16711 +7
Misses 146 146
☔ View full report in Codecov by Sentry. |
multiphaseCFD
approved these changes
Oct 10, 2023
AmintorDusko
approved these changes
Oct 11, 2023
...ne_lightning/core/src/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.cpp
Outdated
Show resolved
Hide resolved
AmintorDusko
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… kernels.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
The
LMimplementation requires less memory and is faster for large state vectors, and hence it is the default implementation for most operations.LM::GeneratorDoubleExcitation,LM::GeneratorDoubleExcitationMinus,LM::GeneratorDoubleExcitationPluskernels are missing.Description of the Change:
Implement
LM::GeneratorDoubleExcitation,LM::GeneratorDoubleExcitationMinus,LM::GeneratorDoubleExcitationPluskernels and set all default kernels toLM.Benefits:
Lower memory footprint and faster calculations for large state vectors.
Possible Drawbacks:
Related GitHub Issues: