-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Lightning Qubit and Lightning Kokkos backends in a single improved repository #472
Conversation
…d Lightning Kokkos backends Co-authored-by: vincentmr <vincent.michaud-rioux@xanadu.ai>
The update dev version action will continue to fail because the script looks for the version in a single place and the _version.py file changed place. Not much to be done here. |
[sc-38802] |
Codecov is activated, and the upload pypi actions are present. |
I remember that docs and benchmarks will come in follow-up PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few questions and suggestions, but look good to me.
…ng without binaries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the hard work here!
Approving, and overriding the dev version failure, which will be rectified upon merging this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to go. Nice work tying all the strings together.
Context: This PR creates an improved structure for the Lightning repository, and merges Lightning Qubit and Lightning Kokkos in a single repository.
Description of the Change:
Complete overhaul of repository code.
Benefits:
All of them.
Possible Drawbacks:
Not aware of it.
Related GitHub Issues: