-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating capabilities dictionary, requirements.txt and black CI check #45
Conversation
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 49 52 +3
=========================================
+ Hits 49 52 +3
Continue to review full report at Codecov.
|
pip install numpy pybind11 pytest pytest-cov pytest-mock flaky | ||
cd main | ||
python -m pip install --upgrade pip | ||
pip install git+https://github.com/PennyLaneAI/pennylane.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is temporary. Need the latest PennyLane with the update of capabilities
. Need to revert before release.
@@ -70,6 +70,8 @@ jobs: | |||
|
|||
- name: Install cibuildwheel | |||
run: | | |||
python -m pip install --upgrade pip | |||
pip install git+https://github.com/PennyLaneAI/pennylane.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not forget all the places we'll need to shortly change back!
"The number of wires exceeds 16, reverting to NumPy-based evaluation.", | ||
UserWarning, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
black
@@ -168,7 +168,8 @@ def build_extensions(self): | |||
|
|||
requirements = [ | |||
"numpy", | |||
"pennylane>=0.11.0", | |||
"pennylane @ git+https://github.com/PennyLaneAI/pennylane.git", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be reverted
cd main | ||
python -m pip install --upgrade pip | ||
pip install git+https://github.com/PennyLaneAI/pennylane.git | ||
pip install -r requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was discovered by Maria, that we were not depending on requirements.txt
here
@@ -54,7 +54,10 @@ jobs: | |||
|
|||
- name: Get required Python packages | |||
run: | | |||
pip install numpy pybind11 pytest pytest-cov pytest-mock flaky | |||
cd main | |||
python -m pip install --upgrade pip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added pip
upgrades just for making sure all is good...
uses: lgeiger/black-action@v1.0.1 | ||
with: | ||
args: "-l 100 pennylane_lightning/ --check" | ||
- name: Cancel Previous Runs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the black update that was needed for each PennyLane plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @antalszava!
@@ -1,5 +1,7 @@ | |||
flaky | |||
numpy | |||
pennylane>=0.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When should we pin this, I guess in a follow up PR we'd pin this to ==0.12
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, in the version bump PR. Note, that that PR should pass checks only when PL v0.12 has been released.
@@ -70,6 +70,8 @@ jobs: | |||
|
|||
- name: Install cibuildwheel | |||
run: | | |||
python -m pip install --upgrade pip | |||
pip install git+https://github.com/PennyLaneAI/pennylane.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not forget all the places we'll need to shortly change back!
black
formatting CI check