Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating capabilities dictionary, requirements.txt and black CI check #45

Merged
merged 10 commits into from
Oct 13, 2020

Conversation

antalszava
Copy link
Contributor

@antalszava antalszava commented Sep 28, 2020

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           49        52    +3     
=========================================
+ Hits            49        52    +3     
Impacted Files Coverage Δ
pennylane_lightning/lightning_qubit.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80580ff...4acee96. Read the comment docs.

@antalszava antalszava changed the title Redefining capabilities Updating capabilities dictionary, requirements.txt and black CI check Oct 13, 2020
pip install numpy pybind11 pytest pytest-cov pytest-mock flaky
cd main
python -m pip install --upgrade pip
pip install git+https://github.com/PennyLaneAI/pennylane.git
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is temporary. Need the latest PennyLane with the update of capabilities. Need to revert before release.

@@ -70,6 +70,8 @@ jobs:

- name: Install cibuildwheel
run: |
python -m pip install --upgrade pip
pip install git+https://github.com/PennyLaneAI/pennylane.git
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be removed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not forget all the places we'll need to shortly change back!

Comment on lines +96 to +97
"The number of wires exceeds 16, reverting to NumPy-based evaluation.",
UserWarning,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

black

@@ -168,7 +168,8 @@ def build_extensions(self):

requirements = [
"numpy",
"pennylane>=0.11.0",
"pennylane @ git+https://github.com/PennyLaneAI/pennylane.git",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be reverted

@antalszava antalszava requested a review from trbromley October 13, 2020 16:28
cd main
python -m pip install --upgrade pip
pip install git+https://github.com/PennyLaneAI/pennylane.git
pip install -r requirements.txt
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was discovered by Maria, that we were not depending on requirements.txt here

@@ -54,7 +54,10 @@ jobs:

- name: Get required Python packages
run: |
pip install numpy pybind11 pytest pytest-cov pytest-mock flaky
cd main
python -m pip install --upgrade pip
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added pip upgrades just for making sure all is good...

uses: lgeiger/black-action@v1.0.1
with:
args: "-l 100 pennylane_lightning/ --check"
- name: Cancel Previous Runs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the black update that was needed for each PennyLane plugin

Copy link
Contributor

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @antalszava!

@@ -1,5 +1,7 @@
flaky
numpy
pennylane>=0.11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When should we pin this, I guess in a follow up PR we'd pin this to ==0.12?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, in the version bump PR. Note, that that PR should pass checks only when PL v0.12 has been released.

@@ -70,6 +70,8 @@ jobs:

- name: Install cibuildwheel
run: |
python -m pip install --upgrade pip
pip install git+https://github.com/PennyLaneAI/pennylane.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not forget all the places we'll need to shortly change back!

@antalszava antalszava merged commit 049dfc4 into master Oct 13, 2020
@antalszava antalszava deleted the capabilities_update branch October 13, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants