make compatible with new return types spec #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
|
[sc-35004] |
Codecov Report
@@ Coverage Diff @@
## master #427 +/- ##
=======================================
Coverage 99.82% 99.82%
=======================================
Files 50 50
Lines 4624 4634 +10
=======================================
+ Hits 4616 4626 +10
Misses 8 8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
AmintorDusko
approved these changes
Apr 5, 2023
AmintorDusko
reviewed
Apr 6, 2023
AmintorDusko
reviewed
Apr 6, 2023
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
Closed
1 task
|
Just a note, the broken MacOS builds are being worked on in #428 and I will notify here once complete and ready for review. |
5 tasks
|
Note, once the PR #428 is approved, we can merge onto this PR and then go to master |
* Allow brew clang version to be set through env var * Fix format * Auto update version * retry the clang 15 pin * Again * Remove whitespace * Fix llvm path * Install correct OMP version * Reorder libomp install for MacOS * Attempt to upgrade all clang & libomp pins for MacOS * Keep clang15 from brew and pull libomp version explicitly into CMake * Add missing comma * Explicitly add setuptools as it is not found on MacOS builds * Adapt to use fun instead of check_output * Retry to find OpenMP * Fallback to MacOS native compiler and libomp@16 from brew * Update MacOS runner to access newer compiler version * Update MacOS runner to access newer compiler version for entire workload * Use in-built compiler and brew libomp for all MacOS * Remove redundant install * Remove ARM libomp * Update setup.py Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com> * Remove ARM libomp * Ensure libomp brew check is guarded * Move OpenMP checks to better suit where they are found * Explicitly disable OpenMP for M1 macs in respective section --------- Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com> Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
With Pennylane PR #3957: PennyLaneAI/pennylane#3957 , the new return types system is enabled by default.
To make sure lightning works with pennylane master, we need to change the return shape from
adjoint_jacobian. The return shape fromexecutein handled insideQubitDevice.Description of the Change:
The changes to the source code are:
adjoint_jacobianto match the new nested tuples specificationtape.get_parametersto eliminate deprecation warningreduction="extend"is requested.The changes to the tests are:
finite_difftoparam_shift, as finite diff was causing errors with float32Benefits:
It works with PennyLane master.
Possible Drawbacks:
None
Related GitHub Issues:
None