Remove run-time dependency on ninja #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
…ing into remove_deps
Codecov Report
@@ Coverage Diff @@
## master #414 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 49 49
Lines 4459 4459
=======================================
Hits 4454 4454
Misses 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
AmintorDusko
approved these changes
Feb 6, 2023
chaeyeunpark
reviewed
Feb 6, 2023
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
chaeyeunpark
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Ninja availability for lightning should be a compile time dependency only. Currently, it is listed as a runtime dependency.
Description of the Change: Remove ninja as a runtime dependency, and allow optional use at compile time in unavailable.
Benefits: Better support on platforms without spack wheels.
Possible Drawbacks:
Related GitHub Issues: