Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Candidate V0.28.2 #408

Merged
merged 31 commits into from
Jan 26, 2023
Merged

Release Candidate V0.28.2 #408

merged 31 commits into from
Jan 26, 2023

Conversation

AmintorDusko
Copy link
Contributor

@AmintorDusko AmintorDusko commented Jan 26, 2023

Context: Version 0.28.1 has a Python versioning bug while building Linux wheels.

Description of the Change: Fix Python module versioning for Linux wheels.

Benefits: Wheels will be built properly.

Possible Drawbacks:

Related GitHub Issues:

@AmintorDusko AmintorDusko marked this pull request as ready for review January 26, 2023 13:09
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #408 (e0b31e7) into master (b8213b6) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #408   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files          49       49           
  Lines        4463     4463           
=======================================
  Hits         4458     4458           
  Misses          5        5           
Impacted Files Coverage Δ
pennylane_lightning/_version.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@multiphaseCFD
Copy link
Member

Nice work @AmintorDusko! Thanks. Just leave a minor question there.

requirements-dev.txt Outdated Show resolved Hide resolved
.github/workflows/wheel_macos_x86_64.yml Outdated Show resolved Hide resolved
.github/workflows/wheel_win_x86_64.yml Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
multiphaseCFD
multiphaseCFD previously approved these changes Jan 26, 2023
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Amintor.

.github/CHANGELOG.md Outdated Show resolved Hide resolved
.github/workflows/wheel_macos_x86_64.yml Outdated Show resolved Hide resolved
.github/workflows/wheel_win_x86_64.yml Outdated Show resolved Hide resolved
requirements-dev.txt Outdated Show resolved Hide resolved
@AmintorDusko
Copy link
Contributor Author

AmintorDusko commented Jan 26, 2023

This branch was forked to v0.28.2_release that was tagged for release.
Now, this PR will be updated for merging into the master.

@AmintorDusko AmintorDusko changed the base branch from v0.28.1_rc to master January 26, 2023 16:48
@AmintorDusko AmintorDusko dismissed multiphaseCFD’s stale review January 26, 2023 16:48

The base branch was changed.

Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks!

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! 🥇

@AmintorDusko AmintorDusko merged commit 17c01cd into master Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants