Pin the CMAKE version #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #387 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 49 49
Lines 4469 4469
=======================================
Hits 4464 4464
Misses 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
[sc-29794] |
mlxd
reviewed
Nov 22, 2022
Co-authored-by: Lee James O'Riordan <mlxd@users.noreply.github.com>
|
Thank you, @chaeyeunpark and @mlxd! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Pin CMake to 3.24.x in wheel-builder to avoid Python not found error in CMake 3.25, when building wheels for PennyLane-Lightning-GPU.
Description of the Change:
All wheels are consistently pinned to the same CMAKE version.
Benefits:
When building Linux wheels for PennyLane-Lightning-GPU, the building process will have a consistent CMAKE version throughout the suite.
Possible Drawbacks:
Related GitHub Issues: