-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated wheel_linux_x86_64.yml #373
Conversation
Codecov Report
@@ Coverage Diff @@
## master #373 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 49 49
Lines 4401 4401
=======================================
Hits 4396 4396
Misses 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MonitSharma
Since the builds are not proceeding due to an external 404 error, can we try one addition to the install commands (listed below):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MonitSharma
One final suggestion, as the update isn't being seen by the build-step. This is due to the shell for the CIBW_BEFORE_BUILD
and actual compilation being different, so the environment is not carried across. I have added a suggestion that should fix this and use the new compiler.
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @MonitSharma.Thank you for your contribution.
Nothing more from me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @MonitSharma Happy to approve.
We will manually update the dev ID before merging.
Thanks again for your contribution @MonitSharma |
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: Update wheel-builder compiler from GCC 10.x to GCC 11.x
Description of the Change: Installed GCC11 onto the building container, and updated the wheeler builder compiler to GCC 11 and g++ 11
Benefits: The update brings improved supports for newer C++ features.
Possible Drawbacks:
Related GitHub Issues: #368