Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated wheel_linux_x86_64.yml #373

Merged
merged 7 commits into from
Oct 12, 2022
Merged

Updated wheel_linux_x86_64.yml #373

merged 7 commits into from
Oct 12, 2022

Conversation

MonitSharma
Copy link
Contributor

@MonitSharma MonitSharma commented Oct 6, 2022

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context: Update wheel-builder compiler from GCC 10.x to GCC 11.x

Description of the Change: Installed GCC11 onto the building container, and updated the wheeler builder compiler to GCC 11 and g++ 11

Benefits: The update brings improved supports for newer C++ features.

Possible Drawbacks:

Related GitHub Issues: #368

@AmintorDusko AmintorDusko self-requested a review October 6, 2022 19:20
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #373 (f8afd85) into master (2405af8) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #373   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files          49       49           
  Lines        4401     4401           
=======================================
  Hits         4396     4396           
  Misses          5        5           
Impacted Files Coverage Δ
pennylane_lightning/_version.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mlxd mlxd self-requested a review October 7, 2022 17:12
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MonitSharma
Since the builds are not proceeding due to an external 404 error, can we try one addition to the install commands (listed below):

.github/workflows/wheel_linux_x86_64.yml Show resolved Hide resolved
@MonitSharma MonitSharma requested review from mlxd and removed request for AmintorDusko October 7, 2022 19:19
.github/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MonitSharma
One final suggestion, as the update isn't being seen by the build-step. This is due to the shell for the CIBW_BEFORE_BUILD and actual compilation being different, so the environment is not carried across. I have added a suggestion that should fix this and use the new compiler.

.github/workflows/wheel_linux_x86_64.yml Show resolved Hide resolved
MonitSharma and others added 2 commits October 8, 2022 07:25
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
@MonitSharma MonitSharma requested a review from mlxd October 8, 2022 04:56
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @MonitSharma.Thank you for your contribution.
Nothing more from me.

Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @MonitSharma Happy to approve.

We will manually update the dev ID before merging.

@mlxd mlxd merged commit 43c70b4 into PennyLaneAI:master Oct 12, 2022
@mlxd
Copy link
Member

mlxd commented Oct 12, 2022

Thanks again for your contribution @MonitSharma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants