Update Kokkos and Kokkos Kernels to 3.7.00 #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
==========================================
- Coverage 99.88% 99.88% -0.01%
==========================================
Files 49 49
Lines 4406 4403 -3
==========================================
- Hits 4401 4398 -3
Misses 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Hi @mlxd, This PR: We are faster and use less memory now. 😉 |
|
Awesome result! Glad to see we can circumvent that allocation. |
AmintorDusko
requested review from
chaeyeunpark,
multiphaseCFD and
trevor-vincent
chaeyeunpark
reviewed
Oct 4, 2022
trevor-vincent
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Upgrade Kokkos and Kokkos Kernels to the 3.7.00 version, and improve our sparse matrix-vector product implementation.
Description of the Change:
Upgrade Kokkos and Kokkos Kernels to the 3.7.00 version
Improve our sparse matrix-vector product implementation.
Benefits: The new implementation is faster and uses less memory.
Possible Drawbacks:
Related GitHub Issues: