-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tests and checks CI/CD pipelines #353
Conversation
Hello. You may have forgotten to update the changelog!
|
[sc-25948] |
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
==========================================
- Coverage 99.78% 98.39% -1.40%
==========================================
Files 49 49
Lines 4160 4163 +3
==========================================
- Hits 4151 4096 -55
- Misses 9 67 +58
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I intend to fill the changelog and merge this PR only after the Release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AmintorDusko
A few comments below. Also, it may be worth updating all the runner images from 20.04 to 22.04.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @AmintorDusko! Just few comments.
Thanks @AmintorDusko for the nice work! No more comments from my side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work! I just have suggestions on the benchmark.
Co-authored-by: Chae-Yeun Park <chae-yeun@xanadu.ai>
Co-authored-by: Chae-Yeun Park <chae-yeun@xanadu.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @AmintorDusko! I think @mlxd needs to change the required CI names in the settings (ubuntu-20.24 to ubuntu-22.04).
@mlxd, I summon thee! |
Should we be concerned about the coverage drop? |
I don't think so. This PR did nothing directly regarding coverage. |
This might be work for other PR, though. The report shows that the drop in coverage is connected with cpu_kernels. |
Context:
Checks and tests are, at the moment, slowing down the CI/CD pipeline.
Some have a running time greater than 20 minutes.
Description of the Change:
Introduction of Kokkos caching for tests and checks, and removal of redundancies.
Benefits:
The expected benefit is to have tests and checks running in less than 10 minutes.
Possible Drawbacks:
Not aware of any.
Related GitHub Issues:
#352