Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove op arithmetic observable support #326

Merged
merged 6 commits into from
Aug 8, 2022
Merged

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Aug 8, 2022

DefaultQubit supports observable measurement of the new Sum, Prod, and SProd classes. Lightning does not yet support these observables, so we need to remove them from the list of supported observables.

In the longer term, we should determine what is necessary to support these general observables.

@albi3ro albi3ro requested review from mlxd and chaeyeunpark August 8, 2022 14:28
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

Test Report (Linux, Kokkos, and Kokkos Kernels) on Ubuntu

           1 files  ±0             1 suites  ±0   2s ⏱️ ±0s
       956 tests ±0         956 ✔️ ±0  0 💤 ±0  0 ±0 
234 969 runs  ±0  234 969 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 600184e. ± Comparison against base commit 921cb88.

♻️ This comment has been updated with latest results.

Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @albi3ro

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #326 (600184e) into master (921cb88) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #326   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files          73       73           
  Lines        5108     5115    +7     
=======================================
+ Hits         5095     5102    +7     
  Misses         13       13           
Impacted Files Coverage Δ
pennylane_lightning/_version.py 100.00% <100.00%> (ø)
pennylane_lightning/lightning_qubit.py 99.63% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@albi3ro albi3ro merged commit e1f91ac into master Aug 8, 2022
@albi3ro albi3ro deleted the no-op-arithmetic-support branch August 8, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants