-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallelize wheel-builds where applicable #314
Conversation
…ane-lightning into improvement/workflows
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 38 38
Lines 3920 3920
=======================================
Hits 3912 3912
Misses 8 8
Continue to review full report at Codecov.
|
Pull request events are triggering all wheels workflows, and artifacts uploaded, for tests. |
Benchmarks:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing but some tidy-up suggestions for when we are ready. Great work putting this together! @multiphaseCFD & @isschoch can you both touch-base with @AmintorDusko to help check the MacOS wheels locally when you have time?
Will try it and get back to you soon @AmintorDusko @mlxd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR 🥇 . Only found a small typo in the comments, not really important but thought I would mention it
Context:
This PR will parallelize wheel-builds
Description of the Change:
Benefits:
Possible Drawbacks:
Not that I'm aware of.
Related GitHub Issues: