Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallelize wheel-builds where applicable #314

Merged
merged 11 commits into from
Jul 20, 2022
Merged

Conversation

AmintorDusko
Copy link
Contributor

@AmintorDusko AmintorDusko commented Jul 13, 2022

Context:
This PR will parallelize wheel-builds

Description of the Change:

  • Wheel-builds parallelized where applicable.

Benefits:

  • Faster wheel-builds time.

Possible Drawbacks:
Not that I'm aware of.

Related GitHub Issues:

@AmintorDusko AmintorDusko added the WIP Work-in-progress issue. Not for general fixing. label Jul 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2022

Test Report (Linux, Kokkos, and Kokkos Kernels) on Ubuntu

           1 files  ±0             1 suites  ±0   1s ⏱️ ±0s
       975 tests ±0         975 ✔️ ±0  0 💤 ±0  0 ±0 
229 280 runs  ±0  229 280 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit dd4bfca. ± Comparison against base commit 677e259.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #314 (8cc15b3) into master (677e259) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 8cc15b3 differs from pull request most recent head dd4bfca. Consider uploading reports for the commit dd4bfca to get more accurate results

@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   99.79%   99.79%           
=======================================
  Files          38       38           
  Lines        3920     3920           
=======================================
  Hits         3912     3912           
  Misses          8        8           
Impacted Files Coverage Δ
pennylane_lightning/_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 677e259...dd4bfca. Read the comment docs.

@AmintorDusko AmintorDusko changed the title [WIP] Improvements to CI/CD workflows Parallelize wheel-builds where applicable Jul 15, 2022
@AmintorDusko
Copy link
Contributor Author

Pull request events are triggering all wheels workflows, and artifacts uploaded, for tests.
This will be reverted before merging.

@AmintorDusko
Copy link
Contributor Author

Benchmarks:

  Master Parallel(Py version)
Wheel::Linux::x86_64 34m 5s 12m 30s
Wheel::MacOS::Intel 39m 34s 11m 44s
Wheel::Linux::ARM 6h 0m 0s (time out) 1h 56m
Wheel::Windows::x86_64 14m 12s  
Wheel::MacOS::ARM 27m 15s 15m 3s
Wheel::Linux::PowerPC 5h 45m 55s 1h 26m

@AmintorDusko AmintorDusko removed the WIP Work-in-progress issue. Not for general fixing. label Jul 15, 2022
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing but some tidy-up suggestions for when we are ready. Great work putting this together! @multiphaseCFD & @isschoch can you both touch-base with @AmintorDusko to help check the MacOS wheels locally when you have time?

.github/workflows/wheel_linux_aarch64.yml Outdated Show resolved Hide resolved
.github/workflows/wheel_linux_aarch64.yml Outdated Show resolved Hide resolved
.github/workflows/wheel_linux_ppc64le.yml Outdated Show resolved Hide resolved
.github/workflows/wheel_linux_ppc64le.yml Outdated Show resolved Hide resolved
.github/workflows/wheel_macos_arm64.yml Show resolved Hide resolved
@multiphaseCFD
Copy link
Member

Nothing but some tidy-up suggestions for when we are ready. Great work putting this together! @multiphaseCFD & @isschoch can you both touch-base with @AmintorDusko to help check the MacOS wheels locally when you have time?

Will try it and get back to you soon @AmintorDusko @mlxd

Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks!

Copy link
Contributor

@isschoch isschoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR 🥇 . Only found a small typo in the comments, not really important but thought I would mention it

.github/workflows/wheel_linux_aarch64.yml Outdated Show resolved Hide resolved
@AmintorDusko AmintorDusko merged commit a95cf34 into master Jul 20, 2022
@AmintorDusko AmintorDusko deleted the improvement/workflows branch July 20, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants