-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated tape execution methods #270
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 379 379
=========================================
Hits 379 379
Continue to review full report at Codecov.
|
…e-lightning into remove_tape_execute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
@@ -320,12 +320,9 @@ def test_gradients(self, op, obs, tol, dev, C): | |||
qml.expval(obs(wires=0)) | |||
qml.expval(qml.PauliZ(wires=1)) | |||
|
|||
tape.execute(dev) | |||
dev.trainable_params = set(range(1, 1 + op.num_params)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maliasadi can this line be deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is added to the grad_F
lambda expr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @maliasadi
Context:
Fix issue #269.