Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated tape execution methods #270

Merged
merged 4 commits into from
Mar 22, 2022
Merged

Conversation

maliasadi
Copy link
Member

Context:
Fix issue #269.

@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #270 (e069f0d) into master (5e01cf9) will not change coverage.
The diff coverage is 100.00%.

❗ Current head e069f0d differs from pull request most recent head 2908855. Consider uploading reports for the commit 2908855 to get more accurate results

@@            Coverage Diff            @@
##            master      #270   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          379       379           
=========================================
  Hits           379       379           
Impacted Files Coverage Δ
pennylane_lightning/_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e01cf9...2908855. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2022

Test Report (C++) on Ubuntu

           1 files  ±0             1 suites  ±0   0s ⏱️ ±0s
       660 tests ±0         660 ✔️ ±0  0 💤 ±0  0 ±0 
228 174 runs  ±0  228 174 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 2908855. ± Comparison against base commit 5e01cf9.

♻️ This comment has been updated with latest results.

Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@@ -320,12 +320,9 @@ def test_gradients(self, op, obs, tol, dev, C):
qml.expval(obs(wires=0))
qml.expval(qml.PauliZ(wires=1))

tape.execute(dev)
dev.trainable_params = set(range(1, 1 + op.num_params))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maliasadi can this line be deleted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is added to the grad_F lambda expr.

Copy link
Contributor

@chaeyeunpark chaeyeunpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @maliasadi

@maliasadi maliasadi merged commit 4c14421 into master Mar 22, 2022
@maliasadi maliasadi deleted the remove_tape_execute branch March 22, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants